Skip to content

Commit c60e20c

Browse files
committed
DOC: Add missing docstrings
1 parent 693741f commit c60e20c

File tree

2 files changed

+44
-8
lines changed

2 files changed

+44
-8
lines changed

vimiv/gui/metadatawidget.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class MetadataWidget(QLabel):
3333
_mainwindow_width: width of the mainwindow.
3434
_path: Absolute path of the current image to load metadata of.
3535
_current_set: Holds a string of the currently selected keyset.
36-
_handler: MetadataHandler for _path or None. Use the handler property to access.
36+
_handler: MetadataHandler for _path or None. Accessed via handler property.
3737
"""
3838

3939
STYLESHEET = """

vimiv/imutils/metadata.py

Lines changed: 43 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,13 @@
2525

2626

2727
class _InternalKeyHandler(dict):
28+
"""Handler to load all internal keys of a single image.
29+
30+
Attributes:
31+
_path: Apsolute path of the image to load the metadata of.
32+
_reader: QImageReader or None of _path. Accessed via reder property.
33+
"""
34+
2835
def __init__(self, path: str):
2936
super().__init__(
3037
{
@@ -39,27 +46,38 @@ def __init__(self, path: str):
3946

4047
@property
4148
def reader(self) -> QImageReader:
49+
"""Return QImageReader instance of _path."""
4250
if self._reader is None:
4351
self._reader = QImageReader(self._path)
4452
return self._reader
4553

4654
def _get_filesize(self):
55+
"""Get the file size."""
4756
return files.get_size_file(self._path)
4857

4958
def _get_filetype(self):
59+
"""Get the file type."""
5060
return files.imghdr.what(self._path)
5161

5262
def _get_xdimension(self):
63+
"""Get the x dimension in pixels."""
5364
return self.reader.size().width()
5465

5566
def _get_ydimension(self):
67+
"""Get the y dimension in pixels."""
5668
return self.reader.size().height()
5769

5870
def __getitem__(self, key: str) -> Tuple[str, str, str]:
71+
"""Intrypoint to extract the key of the image at _path.
72+
73+
Args:
74+
key: internal key to fetch.
75+
"""
5976
key, func = super().get(key.lower())
6077
return (key, key, func())
6178

6279
def get_keys(self) -> Iterable[str]:
80+
"""Returns a sequence of all available metadata keys."""
6381
return (key for key, _ in super().values())
6482

6583

@@ -94,6 +112,11 @@ def get_date_time(self) -> str:
94112
self.raise_exception("Retrieving exif date-time")
95113

96114
def fetch_key(self, _base_key: str) -> Tuple[str, str, str]:
115+
"""Fetch a single metadata key.
116+
117+
Args:
118+
_base_key: metadata key to fetch.
119+
"""
97120
self.raise_exception("Getting formatted keys")
98121

99122
def get_keys(self) -> Iterable[str]:
@@ -269,6 +292,7 @@ def fetch_key(self, base_key: str) -> Tuple[str, str, str]:
269292
return None
270293

271294
def get_keys(self) -> Iterable[str]:
295+
"""Return a iteable of all available metadata keys."""
272296
return (key for key in self._metadata if not is_hex(key.rpartition(".")[2]))
273297

274298
def copy_metadata(self, dest: str, reset_orientation: bool = True) -> None:
@@ -330,7 +354,13 @@ def _external_handler(self) -> ExternalKeyHandler:
330354
return self._ext_handler
331355

332356
def fetch_keys(self, desired_keys: Sequence[str]) -> Dict[Any, Tuple[str, str]]:
333-
"""Throws: UnsupportedMetadataOperation"""
357+
"""Extracts a list of metadata keys.
358+
359+
Throws: UnsupportedMetadataOperation.
360+
361+
Args:
362+
desired_keys: list of metadata keys to extract.
363+
"""
334364
metadata = dict()
335365

336366
for base_key in desired_keys:
@@ -344,6 +374,18 @@ def fetch_keys(self, desired_keys: Sequence[str]) -> Dict[Any, Tuple[str, str]]:
344374

345375
return metadata
346376

377+
def fetch_key(self, key: str) -> Tuple[str, str, str]:
378+
"""Extracts a single metadata key.
379+
380+
Throws: UnsupportedMetadataOperation.
381+
382+
Args:
383+
key: single metadata key to extract.
384+
"""
385+
if key.lower().startswith("vimiv"):
386+
return self._internal_handler[key]
387+
return self._external_handler.fetch_key(key)
388+
347389
def get_keys(self) -> Iterable[str]:
348390
"""Retrieve the name of all metadata keys available.
349391
@@ -353,12 +395,6 @@ def get_keys(self) -> Iterable[str]:
353395
self._internal_handler.get_keys(), self._external_handler.get_keys()
354396
)
355397

356-
def fetch_key(self, key: str) -> Tuple[str, str, str]:
357-
"""Throws: UnsupportedMetadataOperation"""
358-
if key.lower().startswith("vimiv"):
359-
return self._internal_handler[key]
360-
return self._external_handler.fetch_key(key)
361-
362398

363399
class ExifOrientation:
364400
"""Namespace for exif orientation tags.

0 commit comments

Comments
 (0)