Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for uint16 and uint32 #12

Closed
karalabe opened this issue Jul 26, 2024 · 3 comments
Closed

Add support for uint16 and uint32 #12

karalabe opened this issue Jul 26, 2024 · 3 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@karalabe
Copy link
Owner

Adding the support is analogous to #10, just look at uint64 for the little endian handling instead.

Adding the tests can be done via adding the uint16/32 types from here: https://github.com/ethereum/consensus-specs/blob/e9be4e2e3aeb8d0fbe3bff800328445e21a1fdf3/tests/generators/ssz_generic/ssz_container.py#L14, specifically SmallTestStruct, FixedTestStruct, VarTestStruct and ComplexTestStruct as done https://github.com/karalabe/ssz/pull/11/files#diff-2eb949c59ea6f7b5ead391aeccb29b795000d268c46d983c6142cef2651d72c1 and called in the tests.

@karalabe karalabe added the good first issue Good for newcomers label Jul 26, 2024
@karalabe karalabe added this to the 0.3.0 milestone Jul 26, 2024
@raxhvl
Copy link

raxhvl commented Jul 26, 2024

I have no idea what this is. But I'm in. Will keep you posted.

@Lavishq
Copy link
Contributor

Lavishq commented Jul 26, 2024

saw it on twitter (x) and didnt know what that is but started working on it-
as the resources was provided it was ez :)`

#15

@karalabe
Copy link
Owner Author

Done via #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants