From be7cad06ba748d0258422c213084f0d666f3e93a Mon Sep 17 00:00:00 2001 From: Michele Costa Date: Wed, 29 Jan 2025 14:41:07 +0000 Subject: [PATCH] 3: remove unreachable code in gpsd and gpspipe process handlers --- pkg/daemon/gpsd.go | 7 ------- pkg/daemon/gpspipe.go | 8 -------- 2 files changed, 15 deletions(-) diff --git a/pkg/daemon/gpsd.go b/pkg/daemon/gpsd.go index d2fc6cef..0f7521d3 100644 --- a/pkg/daemon/gpsd.go +++ b/pkg/daemon/gpsd.go @@ -178,13 +178,6 @@ func (g *GPSD) CmdRun(stdoutToSocket bool) { glog.Infof("%s cmd: %+v", g.Name(), g.cmd) g.cmd.Stderr = os.Stderr var err error - if err != nil { - glog.Errorf("CmdRun() error creating StdoutPipe for %s: %v", g.Name(), err) - if g.stopped { - return - } - time.Sleep(5 * time.Second) - } // Don't restart after termination if !g.Stopped() { time.Sleep(1 * time.Second) diff --git a/pkg/daemon/gpspipe.go b/pkg/daemon/gpspipe.go index 22ade171..81049414 100644 --- a/pkg/daemon/gpspipe.go +++ b/pkg/daemon/gpspipe.go @@ -114,14 +114,6 @@ func (gp *gpspipe) CmdRun(stdoutToSocket bool) { glog.Infof("%s cmd: %+v", gp.Name(), gp.cmd) gp.cmd.Stderr = os.Stderr var err error - if err != nil { - glog.Errorf("CmdRun() error creating StdoutPipe for %s: %v", gp.Name(), err) - if gp.Stopped() { - return - } - time.Sleep(1 * time.Second) - continue - } // Don't restart after termination if !gp.Stopped() { time.Sleep(1 * time.Second)