You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Remove Psalm: remove psalm/phar dependency, psalm.xml, and update scripts
* Move ulid method from SpecialAssertions to StringAssertions and update README
* Add every, some, none methods to ArrayAssertions with tests and README updates
* CS & Update README.md
* Fix PHPDoc return type in StringAssertions for matchesRegularExpression
* Add isResource and isCallable type checking methods with tests and README updates
* Update AGENTS.md: specify PHPStan for lint/typecheck and add dependency management rule
* Implement suggestions: test suites in phpunit.xml, jsonEquals method, isResource/isCallable types
* Remove jsonEquals method and test as per request
Copy file name to clipboardExpand all lines: AGENTS.md
+2-1Lines changed: 2 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -7,6 +7,7 @@ This file outlines the requirements and best practices for adding new assertion
7
7
-**Version Compliance**: Always use the most current version of AGENTS.md and do not rely on cached or outdated copies. Refresh and re-read AGENTS.md before every change to ensure compliance with the latest requirements.
8
8
-**Branching and Commits**: It is forbidden to commit directly to the `main` branch. All changes must be added via pull request from a feature branch. If the current branch is `main`, MUST checkout to a new branch before changing any files. Do not push changes automatically—only push after explicit user request.
9
9
-**Pull Requests**: When creating a pull request, update the PR description with a detailed summary of changes, including new methods added, files modified, and any breaking changes. Ensure the description follows the format: Summary, Changes, Testing, Validation.
10
+
-**Dependency Management**: Remove unused dependencies from composer.json. If a tool (e.g., Psalm) is no longer used, remove its require-dev entry and update scripts accordingly.
10
11
-**Method Signature**: All new methods must be public, accept an optional `$message` parameter (string, default empty), and return `self` to enable fluent chaining.
11
12
-**Type Safety**: Specify strict types for parameters where applicable (e.g., `int|float` for numeric comparisons). Avoid `mixed` unless necessary.
12
13
-**PHPUnit Integration**: Use appropriate PHPUnit assertion methods (e.g., `Assert::assertLessThan`) without named parameters for compatibility.
@@ -49,7 +50,7 @@ This file outlines the requirements and best practices for adding new assertion
49
50
## Validation Steps
50
51
51
52
-**Run Tests**: Execute `./vendor/bin/phpunit tests/FluentAssertions/Asserts/MethodName/MethodNameTest.php` to verify implementation.
52
-
-**Lint and Typecheck**: Run linting and type checking commands (e.g., via composer scripts or direct tools) to ensure code quality.
53
+
-**Lint and Typecheck**: Run PHPStan static analysis via `composer run analyze` to ensure code quality.
53
54
-**Integration**: Ensure the method works in the overall fluent chain without breaking existing functionality.
0 commit comments