Move from Codeclimate to Qlty (#673)

* Switch to qlty reporter

* Fix job name

* Qlty badges

* Drop pinning of rubocop

* No need for unique folder names anymore

Author: anakinj

.codeclimate.yml

@@ -77,14 +77,14 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: coverage-${{ matrix.os }}-${{ matrix.ruby }}-${{ env.SANITIZED_GEMFILE }}
-          path: coverage-*/*.json
+          path: coverage/*.json
           retention-days: 1
 
   coverage:
-    name: Report coverage to Code Climate
+    name: Report coverage to Qlty
     runs-on: ubuntu-latest
     needs: test
-    if: success() && github.ref == 'refs/heads/main'
+    if: success()
     steps:
       - uses: actions/checkout@v4
 
@@ -93,12 +93,10 @@ jobs:
         with:
           merge-multiple: true
 
-      - uses: paambaati/[email protected]
-        env:
-          CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
+      - uses: qltysh/qlty-action/coverage@main
         with:
-          coverageLocations: |
-           ${{github.workspace}}/coverage-*/*.json:simplecov
+          token: ${{ secrets.QLTY_COVERAGE_TOKEN }}
+          files: coverage/*.json
 
   smoke:
     name: Built GEM smoke test

.github/workflows/test.yml

@@ -6,7 +6,6 @@ require 'simplecov_json_formatter'
 SimpleCov.start do
   command_name "Job #{File.basename(ENV['BUNDLE_GEMFILE'])}" if ENV['BUNDLE_GEMFILE']
   project_name 'Ruby JWT - Ruby JSON Web Token implementation'
-  coverage_dir "coverage-#{OpenSSL::Digest::SHA256.hexdigest(ENV.fetch('GITHUB_STEP_SUMMARY', nil))}" if ENV['GITHUB_STEP_SUMMARY']
   add_filter 'spec'
 end
 

.simplecov

@@ -3,5 +3,3 @@
 source 'https://rubygems.org'
 
 gemspec
-
-gem 'rubocop', '~> 1.56.3' # Keep .codeclimate.yml channel in sync with this one

Gemfile

@@ -2,9 +2,8 @@
 
 [![Gem Version](https://badge.fury.io/rb/jwt.svg)](https://badge.fury.io/rb/jwt)
 [![Build Status](https://github.com/jwt/ruby-jwt/actions/workflows/test.yml/badge.svg?branch=main)](https://github.com/jwt/ruby-jwt/actions)
-[![Code Climate](https://codeclimate.com/github/jwt/ruby-jwt/badges/gpa.svg)](https://codeclimate.com/github/jwt/ruby-jwt)
-[![Test Coverage](https://codeclimate.com/github/jwt/ruby-jwt/badges/coverage.svg)](https://codeclimate.com/github/jwt/ruby-jwt/coverage)
-[![Issue Count](https://codeclimate.com/github/jwt/ruby-jwt/badges/issue_count.svg)](https://codeclimate.com/github/jwt/ruby-jwt)
+[![Maintainability](https://qlty.sh/badges/eefe957e-cf90-41f6-b78b-909837542c5f/maintainability.svg)](https://qlty.sh/gh/anakinj/projects/ruby-jwt)
+[![Code Coverage](https://qlty.sh/badges/eefe957e-cf90-41f6-b78b-909837542c5f/test_coverage.svg)](https://qlty.sh/gh/anakinj/projects/ruby-jwt)
 
 A ruby implementation of the [RFC 7519 OAuth JSON Web Token (JWT)](https://tools.ietf.org/html/rfc7519) standard.
 

README.md

@@ -6,6 +6,11 @@
 module JWT
   # The Decode class is responsible for decoding and verifying JWT tokens.
   class Decode
+    # Order is very important - first check for string keys, next for symbols
+    ALGORITHM_KEYS = ['algorithm',
+                      :algorithm,
+                      'algorithms',
+                      :algorithms].freeze
     # Initializes a new Decode instance.
     #
     # @param jwt [String] the JWT to decode.
@@ -70,12 +75,6 @@ def allowed_and_valid_algorithms
       @allowed_and_valid_algorithms ||= allowed_algorithms.select { |alg| alg.valid_alg?(alg_in_header) }
     end
 
-    # Order is very important - first check for string keys, next for symbols
-    ALGORITHM_KEYS = ['algorithm',
-                      :algorithm,
-                      'algorithms',
-                      :algorithms].freeze
-
     def given_algorithms
       alg_key = ALGORITHM_KEYS.find { |key| @options[key] }
       Array(@options[alg_key])

lib/jwt/decode.rb

@@ -68,7 +68,7 @@ def key_digest
       def []=(key, value)
         raise ArgumentError, 'cannot overwrite cryptographic key attributes' if EC_KEY_ELEMENTS.include?(key.to_sym)
 
-        super(key, value)
+        super
       end
 
       private

lib/jwt/jwk/ec.rb

@@ -64,7 +64,7 @@ def key_digest
       def []=(key, value)
         raise ArgumentError, 'cannot overwrite cryptographic key attributes' if HMAC_KEY_ELEMENTS.include?(key.to_sym)
 
-        super(key, value)
+        super
       end
 
       private

lib/jwt/jwk/hmac.rb

@@ -67,7 +67,7 @@ def key_digest
       def []=(key, value)
         raise ArgumentError, 'cannot overwrite cryptographic key attributes' if RSA_KEY_ELEMENTS.include?(key.to_sym)
 
-        super(key, value)
+        super
       end
 
       private