Skip to content

Commit 6aac2d6

Browse files
authored
Add markdown linter (#675)
* Markdown linter * Fix MD files * Fix formatting
1 parent 752ed49 commit 6aac2d6

File tree

8 files changed

+77
-61
lines changed

8 files changed

+77
-61
lines changed

.github/workflows/push_gem.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
---
2-
'on':
3-
push:
4-
tags:
2+
"on":
3+
push:
4+
tags:
55
- v*
6-
name: Push Gem
7-
jobs:
8-
push:
9-
runs-on: ubuntu-latest
10-
permissions:
11-
contents: write
12-
id-token: write
13-
steps:
6+
name: Push Gem
7+
jobs:
8+
push:
9+
runs-on: ubuntu-latest
10+
permissions:
11+
contents: write
12+
id-token: write
13+
steps:
1414
- uses: rubygems/configure-rubygems-credentials@main
1515
with:
1616
role-to-assume: ${{ secrets.RUBYGEMS_PUSH_ROLE }}
@@ -36,4 +36,4 @@
3636
raise "No spec for #{ARGV[0]}" unless spec
3737
print [spec.name, spec.version, spec.platform].join(":")
3838
' "jwt")"
39-
gem await "${gem_tuple}"
39+
gem await "${gem_tuple}"

.github/workflows/test.yml

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
branches:
99
- "*"
1010
jobs:
11-
lint:
11+
rubocop:
1212
name: RuboCop
1313
timeout-minutes: 30
1414
runs-on: ubuntu-latest
@@ -21,6 +21,13 @@ jobs:
2121
bundler-cache: true
2222
- name: Run RuboCop
2323
run: bundle exec rubocop
24+
markdown:
25+
runs-on: ubuntu-latest
26+
steps:
27+
- name: Checkout repository
28+
uses: actions/checkout@v4
29+
- name: Lint Markdown
30+
uses: actionshub/[email protected]
2431
test:
2532
name: ${{ matrix.os }} - Ruby ${{ matrix.ruby }} - ${{ matrix.gemfile }}
2633
runs-on: ${{ matrix.os }}
@@ -44,15 +51,15 @@ jobs:
4451
include:
4552
- os: ubuntu-latest
4653
ruby: "3.0"
47-
gemfile: 'gemfiles/openssl.gemfile'
54+
gemfile: "gemfiles/openssl.gemfile"
4855
experimental: false
4956
- os: ubuntu-latest
5057
ruby: "truffleruby-head"
51-
gemfile: 'gemfiles/standalone.gemfile'
58+
gemfile: "gemfiles/standalone.gemfile"
5259
experimental: true
5360
- os: ubuntu-latest
5461
ruby: "head"
55-
gemfile: 'gemfiles/standalone.gemfile'
62+
gemfile: "gemfiles/standalone.gemfile"
5663
experimental: true
5764
continue-on-error: ${{ matrix.experimental }}
5865
env:

.mdlrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
rules "~MD013"

CHANGELOG.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
[Full Changelog](https://github.com/jwt/ruby-jwt/compare/v2.10.1...main)
66

77
**Breaking changes:**
8+
89
- Require token signature to be verified before accessing payload [#648](https://github.com/jwt/ruby-jwt/pull/648) ([@anakinj](https://github.com/anakinj))
910
- Drop support for the HS512256 algorithm [#650](https://github.com/jwt/ruby-jwt/pull/650) ([@anakinj](https://github.com/anakinj))
1011
- Remove deprecated claim verification methods [#654](https://github.com/jwt/ruby-jwt/pull/654) ([@anakinj](https://github.com/anakinj))
@@ -17,6 +18,7 @@
1718
Take a look at the [upgrade guide](UPGRADING.md) for more details.
1819

1920
**Features:**
21+
2022
- JWT::EncodedToken#verify! method that bundles signature and claim validation [#647](https://github.com/jwt/ruby-jwt/pull/647) ([@anakinj](https://github.com/anakinj))
2123
- Do not override the alg header if already given [#659](https://github.com/jwt/ruby-jwt/pull/659) ([@anakinj](https://github.com/anakinj))
2224
- Make `JWK::KeyFinder` compatible with `JWT::EncodedToken` [#663](https://github.com/jwt/ruby-jwt/pull/663) ([@anakinj](https://github.com/anakinj))
@@ -190,6 +192,7 @@ Take a look at the [upgrade guide](UPGRADING.md) for more details.
190192
- Support OpenSSL >= 3.0 [#496](https://github.com/jwt/ruby-jwt/pull/496) ([@anakinj](https://github.com/anakinj))
191193

192194
**Fixes and enhancements:**
195+
193196
- Bring back the old Base64 (RFC2045) deocode mechanisms [#488](https://github.com/jwt/ruby-jwt/pull/488) ([@anakinj](https://github.com/anakinj))
194197
- Rescue RbNaCl exception for EdDSA wrong key [#491](https://github.com/jwt/ruby-jwt/pull/491) ([@n-studio](https://github.com/n-studio))
195198
- New parameter name for cases when kid is not found using JWK key loader proc [#501](https://github.com/jwt/ruby-jwt/pull/501) ([@anakinj](https://github.com/anakinj))
@@ -200,6 +203,7 @@ Take a look at the [upgrade guide](UPGRADING.md) for more details.
200203
[Full Changelog](https://github.com/jwt/ruby-jwt/compare/v2.4.0...v2.4.1)
201204

202205
**Fixes and enhancements:**
206+
203207
- Raise JWT::DecodeError on invalid signature [\#484](https://github.com/jwt/ruby-jwt/pull/484) ([@freakyfelt!](https://github.com/freakyfelt!))
204208

205209
## [v2.4.0](https://github.com/jwt/ruby-jwt/tree/v2.4.0) (2022-06-06)
@@ -217,6 +221,7 @@ Take a look at the [upgrade guide](UPGRADING.md) for more details.
217221
- Add Support to be able to verify from multiple keys [\#425](https://github.com/jwt/ruby-jwt/pull/425) ([ritikesh](https://github.com/ritikesh))
218222

219223
**Fixes and enhancements:**
224+
220225
- Readme: Typo fix re MissingRequiredClaim [\#451](https://github.com/jwt/ruby-jwt/pull/451) ([antonmorant](https://github.com/antonmorant))
221226
- Fix RuboCop TODOs [\#476](https://github.com/jwt/ruby-jwt/pull/476) ([typhoon2099](https://github.com/typhoon2099))
222227
- Make specific algorithms in README linkable [\#472](https://github.com/jwt/ruby-jwt/pull/472) ([milieu](https://github.com/milieu))
@@ -638,7 +643,7 @@ Take a look at the [upgrade guide](UPGRADING.md) for more details.
638643

639644
**Closed issues:**
640645

641-
- 404 at https://rubygems.global.ssl.fastly.net/gems/jwt-1.5.3.gem [\#137](https://github.com/jwt/ruby-jwt/issues/137)
646+
- 404 at [https://rubygems.global.ssl.fastly.net/gems/jwt-1.5.3.gem](https://rubygems.global.ssl.fastly.net/gems/jwt-1.5.3.gem) [\#137](https://github.com/jwt/ruby-jwt/issues/137)
642647

643648
**Merged pull requests:**
644649

@@ -957,7 +962,3 @@ Take a look at the [upgrade guide](UPGRADING.md) for more details.
957962

958963
- Bumped a version and added a .gemspec using rake build\_gemspec [\#3](https://github.com/jwt/ruby-jwt/pull/3) ([zhitomirskiyi](https://github.com/zhitomirskiyi))
959964
- Added RSA support [\#2](https://github.com/jwt/ruby-jwt/pull/2) ([zhitomirskiyi](https://github.com/zhitomirskiyi))
960-
961-
962-
963-
\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*

CODE_OF_CONDUCT.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,11 @@ Community leaders will follow these Community Impact Guidelines in determining t
7474
## Attribution
7575

7676
This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 2.0,
77-
available at https://www.contributor-covenant.org/version/2/0/code_of_conduct.html.
77+
available at [https://www.contributor-covenant.org/version/2/0/code_of_conduct.html](https://www.contributor-covenant.org/version/2/0/code_of_conduct.html).
7878

7979
Community Impact Guidelines were inspired by [Mozilla's code of conduct enforcement ladder](https://github.com/mozilla/diversity).
8080

8181
[homepage]: https://www.contributor-covenant.org
8282

8383
For answers to common questions about this code of conduct, see the FAQ at
84-
https://www.contributor-covenant.org/faq. Translations are available at https://www.contributor-covenant.org/translations.
84+
[https://www.contributor-covenant.org/faq](https://www.contributor-covenant.org/faq). Translations are available at [https://www.contributor-covenant.org/translations](https://www.contributor-covenant.org/translations).

CONTRIBUTING.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ Implement tests and your change. Don't be shy adding a little something in the [
4444
Add a short description of the change in either the `Features` or `Fixes` section in the [CHANGELOG](CHANGELOG.md) file.
4545

4646
The form of the row (You need to return to the row when you know the pull request id)
47+
4748
```
4849
- Fix a little problem [#123](https://github.com/jwt/ruby-jwt/pull/123) - [@you](https://github.com/you).
4950
```
@@ -87,7 +88,7 @@ git rebase upstream/main
8788
git push origin fix-a-little-problem -f
8889
```
8990

90-
# Releasing a new version
91+
## Releasing a new version
9192

9293
The version is using the [Semantic Versioning](http://semver.org/) and the version is located in the [version.rb](lib/jwt/version.rb) file.
9394
Also update the [CHANGELOG](CHANGELOG.md) to reflect the upcoming version release.

0 commit comments

Comments
 (0)