Update the verifier to 1.384 and make changes in the build.gradle.kts to fix the IJ Verifier for the Flutter plugin

This resolves flutter#8034

Author: jwren

.gitignore

@@ -13,7 +13,6 @@ flutter-gui-tests/.gradle/
 flutter-gui-tests/guitest.log
 flutter-intellij.jar
 flutter-intellij.zip
-third_party/lib/*.jar
 third_party/lib/jxbrowser/*
 !third_party/lib/jxbrowser/jxbrowser-7.41.2.jar
 !third_party/lib/jxbrowser/jxbrowser-swing-7.41.2.jar

build.gradle.kts

@@ -4,6 +4,7 @@
  * found in the LICENSE file.
  */
 
+import org.jetbrains.intellij.platform.gradle.IntelliJPlatform
 import org.jetbrains.intellij.platform.gradle.IntelliJPlatformType
 import org.jetbrains.intellij.platform.gradle.TestFrameworkType
 import org.jetbrains.intellij.platform.gradle.models.ProductRelease
@@ -130,6 +131,7 @@ dependencies {
   }
 }
 
+
 intellijPlatform {
   pluginConfiguration {
     version = flutterPluginVersion
@@ -138,8 +140,46 @@ intellijPlatform {
       untilBuild = untilBuildInput
     }
   }
-}
 
+  // Verifier documentation
+  // https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-extension.html#intellijPlatform-pluginVerification
+  // https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-extension.html#intellijPlatform-pluginVerification-ides
+  pluginVerification {
+    // https://github.com/JetBrains/intellij-plugin-verifier/?tab=readme-ov-file#specific-options
+    // https://github.com/JetBrains/intellij-plugin-verifier
+    cliPath = file("./third_party/lib/verifier-cli-1.384-all.jar")
+    failureLevel = listOf(
+      // TODO(team) Ideally all of the following FailureLevels should be enabled:
+      // TODO(team) Create a tracking issue for each of the following validations
+//      VerifyPluginTask.FailureLevel.COMPATIBILITY_WARNINGS,
+//      VerifyPluginTask.FailureLevel.COMPATIBILITY_PROBLEMS,
+//      VerifyPluginTask.FailureLevel.DEPRECATED_API_USAGES, // https://github.com/flutter/flutter-intellij/issues/7718
+//      VerifyPluginTask.FailureLevel.SCHEDULED_FOR_REMOVAL_API_USAGES,
+      VerifyPluginTask.FailureLevel.EXPERIMENTAL_API_USAGES,
+//      VerifyPluginTask.FailureLevel.INTERNAL_API_USAGES,
+//      VerifyPluginTask.FailureLevel.OVERRIDE_ONLY_API_USAGES,
+      VerifyPluginTask.FailureLevel.NON_EXTENDABLE_API_USAGES,
+      VerifyPluginTask.FailureLevel.PLUGIN_STRUCTURE_WARNINGS,
+//      VerifyPluginTask.FailureLevel.MISSING_DEPENDENCIES,
+      VerifyPluginTask.FailureLevel.INVALID_PLUGIN,
+//      VerifyPluginTask.FailureLevel.NOT_DYNAMIC,
+    )
+    verificationReportsFormats = VerifyPluginTask.VerificationReportsFormats.ALL
+    subsystemsToCheck = VerifyPluginTask.Subsystems.ALL
+    // Mute and freeArgs documentation
+    // https://github.com/JetBrains/intellij-plugin-verifier/?tab=readme-ov-file#specific-options
+    // https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-faq.html#mutePluginVerifierProblems
+    freeArgs = listOf(
+      "-mute",
+      "TemplateWordInPluginId,ForbiddenPluginIdPrefix,TemplateWordInPluginName"
+    )
+    ides {
+      ide(IntelliJPlatformType.AndroidStudio, ideaVersion)
+      // Note, ideally we would have additional targets identified here, however we have been unsuccessful in adding
+      // "recomended()" or select {} support with current versions of gradle & the verifier tool.
+    }
+  }
+}
 // Documentation for printProductsReleases:
 // https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-faq.html#how-to-check-the-latest-available-eap-release
 tasks {

flutter-idea/build.gradle.kts

@@ -7,6 +7,7 @@
 import org.gradle.api.tasks.testing.logging.TestExceptionFormat
 import org.jetbrains.intellij.platform.gradle.IntelliJPlatformType
 import org.jetbrains.intellij.platform.gradle.TestFrameworkType
+import org.jetbrains.intellij.platform.gradle.models.ProductRelease
 import org.jetbrains.intellij.platform.gradle.tasks.VerifyPluginTask
 import org.jetbrains.kotlin.gradle.dsl.JvmTarget
 import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
@@ -72,9 +73,9 @@ dependencies {
     // Documentation on the default target platform methods:
     // https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-dependencies-extension.html#default-target-platforms
     if (ideaProduct == "android-studio") {
-      androidStudio(ideaVersion)
+      create(IntelliJPlatformType.AndroidStudio, ideaVersion)
     } else { // if (ideaProduct == "IC") {
-      intellijIdeaCommunity(ideaVersion)
+      create(IntelliJPlatformType.IntellijIdeaCommunity, ideaVersion)
     }
     testFramework(TestFrameworkType.Platform)
 
@@ -126,13 +127,13 @@ intellijPlatform {
   pluginVerification {
     // https://github.com/JetBrains/intellij-plugin-verifier/?tab=readme-ov-file#specific-options
     // https://github.com/JetBrains/intellij-plugin-verifier
-    cliPath = file("../third_party/lib/verifier-cli-1.379-all.jar")
+    cliPath = file("../third_party/lib/verifier-cli-1.384-all.jar")
     failureLevel = listOf(
       // TODO(team) Ideally all of the following FailureLevels should be enabled:
       // TODO(team) Create a tracking issue for each of the following validations
 //      VerifyPluginTask.FailureLevel.COMPATIBILITY_WARNINGS,
 //      VerifyPluginTask.FailureLevel.COMPATIBILITY_PROBLEMS,
-//      VerifyPluginTask.FailureLevel.DEPRECATED_API_USAGES,
+//      VerifyPluginTask.FailureLevel.DEPRECATED_API_USAGES, // https://github.com/flutter/flutter-intellij/issues/7718
 //      VerifyPluginTask.FailureLevel.SCHEDULED_FOR_REMOVAL_API_USAGES,
       VerifyPluginTask.FailureLevel.EXPERIMENTAL_API_USAGES,
 //      VerifyPluginTask.FailureLevel.INTERNAL_API_USAGES,
@@ -153,18 +154,9 @@ intellijPlatform {
       "TemplateWordInPluginId,ForbiddenPluginIdPrefix,TemplateWordInPluginName"
     )
     ides {
-      if (ideaProduct == "android-studio") {
-        ide(IntelliJPlatformType.AndroidStudio, ideaVersion)
-      } else {
-          ide(IntelliJPlatformType.IntellijIdeaCommunity, ideaVersion)
-        }
-      recommended()
-//      select {
-//        types = listOf(IntelliJPlatformType.AndroidStudio)
-//        channels = listOf(ProductRelease.Channel.RELEASE)
-//        sinceBuild = sinceBuildInput
-//        untilBuild = untilBuildInput
-//      }
+      ide(IntelliJPlatformType.AndroidStudio, ideaVersion)
+      // Note, ideally we would have additional targets identified here, however we have been unsuccessful in adding
+      // "recomended()" or select {} support with current versions of gradle & the verifier tool.
     }
   }
 }