Fixed: Now automatic insertion of bars (|) only when no text is selected

Author: jwdj

CHANGES

@@ -627,3 +627,5 @@ different panes. Tie/untie option added for notes. Broken rhythm
 - Added 'Insert musical symbol' again to the menu again which was removed in 1.3.8.4. Although ABC Assist can insert musical with less hassle, some users really like the old
   menu version. For Linux (Gnome) users these menus are still empty but that is caused by Gnome, not EasyABC.
 - Fixed: Playing selection gave an error: AttributeError: 'bytes' object has no attribute 'encode'  (https://github.com/jwdj/EasyABC/issues/69)
+- Fixed: Now automatic insertion of bars (|) only when no text is selected
+

easy_abc.py

@@ -48,6 +48,8 @@
     unichr = chr
     xrange = range
     def unicode(s):
+        if isinstance(s, bytes):
+            return s.decode()  # assumes utf-8
         return s
     max_int = sys.maxsize
     basestring = str
@@ -6803,18 +6805,19 @@ def OnCharEvent(self, evt):
         if use_typing_assist and in_music_code:
             if c == '-' and no_selection:
                 self.AddTextWithUndo('- ')
+                return
 
             if c == ' ':
                 try:
                     self.FixNoteDurations()
-                    if self.add_bar_if_needed():
+                    if no_selection and self.add_bar_if_needed():
                         return
                     else:
                         evt.Skip()
                 except Exception:
                     evt.Skip()
                     raise
-            elif self.mni_TA_add_bar_auto.IsChecked() and c not in "-/<,'1234567890\"!":
+            elif self.mni_TA_add_bar_auto.IsChecked() and no_selection and c not in "-/<,'1234567890\"!":
                 if c in '|]&':
                     if c == ']':
                         bar_text = '|]'

wxhelper.py

@@ -29,7 +29,7 @@ def append_submenu(menu, label, submenu):
 
 
 def append_menu_item(menu, label, description, handler, kind=wx.ITEM_NORMAL, id=-1, bitmap=None):
-    menu_item = wx.MenuItem(menu, -1, label, description, kind)
+    menu_item = wx.MenuItem(menu, id=wx.ID_ANY, text=label, helpString=description, kind=kind)
     if bitmap is not None:
         menu_item.SetBitmap(bitmap)
     if WX4: