Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate functionality of get_df() into a CLI script #66

Closed
jvivian opened this issue Mar 12, 2024 · 1 comment
Closed

Separate functionality of get_df() into a CLI script #66

jvivian opened this issue Mar 12, 2024 · 1 comment
Labels
enhancement New feature or request medium difficulty a bit more challenging than "good first issue"

Comments

@jvivian
Copy link
Owner

jvivian commented Mar 12, 2024

After talking with @AaronCooke2718 I would like to implement #56 next when I have the time. The goal is to allow someone to run the model with any time-series input, not specific to our project.

Doing so will require replacing get_df() with two input files:

  1. time series x variables matrix (after processing / before normalization -- currently what get_df() generates)
  2. A variables x metadata matrix which includes a factor column that describes the variable-factor relationship

get_df() is referenced in a lot of places, so will need testing of all streamlit pages prior to merge

@jvivian jvivian added enhancement New feature or request medium difficulty a bit more challenging than "good first issue" labels Mar 12, 2024
@jvivian
Copy link
Owner Author

jvivian commented Mar 29, 2024

Implemented in #74 viaDataLoader class @AaronCooke2718

@jvivian jvivian closed this as completed Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium difficulty a bit more challenging than "good first issue"
Projects
None yet
Development

No branches or pull requests

1 participant