Skip to content

Commit 2bb3c47

Browse files
committed
fix(directive): fix minification issue with controller in growlNotification directive
1 parent 6081a3a commit 2bb3c47

File tree

6 files changed

+12
-8
lines changed

6 files changed

+12
-8
lines changed

bower.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-growl-notifications",
3-
"version": "2.0.0",
3+
"version": "2.0.1",
44
"main": [
55
"dist/angular-growl-notifications.js"
66
],

dist/angular-growl-notifications.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ angular.module('growlNotifications.directives')
4747
* @param $element
4848
* @param $attrs
4949
*/
50-
controller: function($scope, $element, $attrs){
50+
controller: ['$scope', '$element', function($scope, $element){
5151

5252
/**
5353
* Placeholder for timer promise
@@ -68,7 +68,7 @@ angular.module('growlNotifications.directives')
6868
}
6969
};
7070

71-
},
71+
}],
7272

7373
/**
7474
* Make the controller available in the directive scope

dist/angular-growl-notifications.min.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "growl-notifications",
3-
"version": "2.0.0",
3+
"version": "2.0.1",
44
"keywords": [
55
"angular",
66
"angularjs",

readme.md

+4
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,10 @@ MIT
109109

110110
## Change log
111111

112+
### v2.0.1
113+
114+
- Fixed issue with minification of controller in `growlNotification` directive (see [this issue](https://github.com/jvandemo/angular-growl-notifications/issues/3)).
115+
112116
### v2.0.0
113117

114118
- Directives have been rewritten for better performance

src/growlNotifications/directives/growlNotification.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ angular.module('growlNotifications.directives')
2525
* @param $element
2626
* @param $attrs
2727
*/
28-
controller: function($scope, $element, $attrs){
28+
controller: ['$scope', '$element', function($scope, $element){
2929

3030
/**
3131
* Placeholder for timer promise
@@ -46,7 +46,7 @@ angular.module('growlNotifications.directives')
4646
}
4747
};
4848

49-
},
49+
}],
5050

5151
/**
5252
* Make the controller available in the directive scope

0 commit comments

Comments
 (0)