Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency issues #33

Open
alerque opened this issue Aug 7, 2021 · 3 comments
Open

Dependency issues #33

alerque opened this issue Aug 7, 2021 · 3 comments

Comments

@alerque
Copy link

alerque commented Aug 7, 2021

First, pillow is required to run the test suite and doesn't seem to be mentioned as a test dependency anywhere. I must be blind, it's right there in requirements-dev.txt.

Second it seems numpy should be listed as a test dependency, not as a regular dependency. It is used directly for tests. I looked through the skip-python code based and it seems the same there, it is never used directly in the library but it is used for the test suite. As such they seem to have it specified properly and the only improper thing is where this shows up and moving it to test deps would be appropriate:

"numpy", # unlisted skia-python dependency, TODO: is this true?

@justvanrossum
Copy link
Owner

justvanrossum commented Aug 7, 2021

My observation is this: in a Python environment without numpy installed, creating a skia.Surface fails:

>>> import skia
>>> skia.Surface(100, 100)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'numpy'
>>> 

@alerque
Copy link
Author

alerque commented Aug 7, 2021

Silly me searching only in their Python code. The usage is in C++ bound with pybind. So yes, this is a skip-python project bug.

@alerque
Copy link
Author

alerque commented Aug 10, 2021

My PR upstream has been merged so this should be fixed in the next release. I guess the thing to do now is leave this open until there is a tagged release with this fix available, then fix this dependency by moving it to tests only after the skia dep is bumped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants