-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency issues #33
Comments
My observation is this: in a Python environment without numpy installed, creating a
|
Silly me searching only in their Python code. The usage is in C++ bound with pybind. So yes, this is a skip-python project bug. |
My PR upstream has been merged so this should be fixed in the next release. I guess the thing to do now is leave this open until there is a tagged release with this fix available, then fix this dependency by moving it to tests only after the skia dep is bumped. |
First, pillow is required to run the test suite and doesn't seem to be mentioned as a test dependency anywhere.I must be blind, it's right there inrequirements-dev.txt
.Second it seems numpy should be listed as a test dependency, not as a regular dependency. It is used directly for tests. I looked through the skip-python code based and it seems the same there, it is never used directly in the library but it is used for the test suite. As such they seem to have it specified properly and the only improper thing is where this shows up and moving it to test deps would be appropriate:
drawbot-skia/setup.py
Line 26 in f9d5314
The text was updated successfully, but these errors were encountered: