-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kokoro numpy >=2.0.2 #24
Comments
Hi thx for the report. Yes, it's the node TTS kokoro : https://github.com/justUmen/Bjornulf_custom_nodes?tab=readme-ov-file#120----kokoro---text-to-speech https://github.com/thewh1teagle/kokoro-onnx require numpy >=2.0.2, and a common one is 1.26.4. I'm not sure how to deal with that for now..., but normally it shouldn't cause any issues. The funny thing is that my kokoro node should still work properly, even without the "required" >=2.0.2 Did you have more than the red message ? Did you experience a crash or something ? I meant before trying "smart" comfyui manager "fix" button. (I don't control that, it's not my code, it's comfy manager stuff. My guess is that it just forced numpy version 2.0.2 and killed your other dependencies at the same time.) You should be able to recover from that with just a I... could force numpy back to 1.26.4 but.... maybe some people have some other dependencies, so I would rather have comfyui do the revert. Just to be clear, when you run everything you had an IMPORT FAILED on my nodes ? or just the red message from numpy. |
I had an IMPORT FAILED on your nodes. They were quarantined in the import fail area of custom nodes so I couldn't use them. |
Just cleaned up a lot of bugs in 0.74. I can't reproduce your error. |
** Platform: Linux |
I tried to install the 'latest' version (which I think was 73) in Comfyui however there was an issue with the numpy version that ultralytics required which was a lower version than what I had installed.
When trying to 'Fix' your nodes in ComfyManager, my install was completely offline requiring some repair.
Unfortunately, the logs got overwritten so I don't have any other information for you so this is just an FYI in case the issue can be easily identified.
The text was updated successfully, but these errors were encountered: