Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kokoro numpy >=2.0.2 #24

Open
rastarr opened this issue Feb 21, 2025 · 4 comments
Open

Kokoro numpy >=2.0.2 #24

rastarr opened this issue Feb 21, 2025 · 4 comments

Comments

@rastarr
Copy link

rastarr commented Feb 21, 2025

I tried to install the 'latest' version (which I think was 73) in Comfyui however there was an issue with the numpy version that ultralytics required which was a lower version than what I had installed.
When trying to 'Fix' your nodes in ComfyManager, my install was completely offline requiring some repair.
Unfortunately, the logs got overwritten so I don't have any other information for you so this is just an FYI in case the issue can be easily identified.

@justUmen
Copy link
Owner

Hi thx for the report.

Yes, it's the node TTS kokoro : https://github.com/justUmen/Bjornulf_custom_nodes?tab=readme-ov-file#120----kokoro---text-to-speech

https://github.com/thewh1teagle/kokoro-onnx require numpy >=2.0.2, and a common one is 1.26.4.

I'm not sure how to deal with that for now..., but normally it shouldn't cause any issues.
You will just have a red message at the first start, comfyui should reverse to 1.26.4 and the message should be gone the next start.

The funny thing is that my kokoro node should still work properly, even without the "required" >=2.0.2

Did you have more than the red message ? Did you experience a crash or something ? I meant before trying "smart" comfyui manager "fix" button. (I don't control that, it's not my code, it's comfy manager stuff. My guess is that it just forced numpy version 2.0.2 and killed your other dependencies at the same time.)

You should be able to recover from that with just a pip install numpy==1.26.4.

I... could force numpy back to 1.26.4 but.... maybe some people have some other dependencies, so I would rather have comfyui do the revert.

Just to be clear, when you run everything you had an IMPORT FAILED on my nodes ? or just the red message from numpy.

@justUmen justUmen changed the title Ultralytics problem Kokoro numpy >=2.0.2 Feb 21, 2025
@rastarr
Copy link
Author

rastarr commented Feb 21, 2025

I had an IMPORT FAILED on your nodes. They were quarantined in the import fail area of custom nodes so I couldn't use them.
Only when I tried to 'fix' them did everything (comfy) stop working. I'm also running in a docker container.
Anyway, I'm not interested in the kokoro node but more the text manipulation stuff but since all your nodes are one bundle, I can't use any of them.
I do certainly appreciate the efforts you've put in to all of them though, some great work indeed

@justUmen
Copy link
Owner

Just cleaned up a lot of bugs in 0.74.

I can't reproduce your error.
Do you use python 3.11 ? 3.12 ?

@rastarr
Copy link
Author

rastarr commented Feb 22, 2025

** Platform: Linux
** Python version: 3.12.9 (main, Feb 05 2025, 11:02:28) [GCC]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants