Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete without trash #497

Closed
notramo opened this issue Apr 27, 2022 · 13 comments · Fixed by #639
Closed

Delete without trash #497

notramo opened this issue Apr 27, 2022 · 13 comments · Fixed by #639
Labels
enhancement New feature or request good first issue This is a good one to do if you want to contribute and don't have much experience
Milestone

Comments

@notramo
Copy link

notramo commented Apr 27, 2022

On Linux with BTRFS, NILFS2, and ZFS, it's not necessary to have a thrash, since these filesystems support snapshots.
On CLI systems which rm without thrash, it's unnecessary complication to have a thrash just for qView, and clean it periodically.
qView should have an option to disable trash (enable direct deletion) in the settings.

@notramo notramo added the enhancement New feature or request label Apr 27, 2022
@A9G-Data-Droid
Copy link

I am unable to delete files from an SMB share with no trash. This might be the reason. Instead of throwing an error, we need to issue a regular filesystem delete on SMB shares.

@vassudanagunta
Copy link

I am unable to delete files from an SMB share with no trash.

I am also unable to delete files from an SMB share, but it does have a trash, at least on the server side (It's just another Mac).

Anyway, if the inability to move files to the trash on SMB shares is what's preventing deletion, then I agree with @A9G-Data-Droid, as long as there a special confirmation dialogue. I can have a checkbox for "don't ask me again".

@jurplel
Copy link
Owner

jurplel commented Aug 8, 2023

I can't believe this isn't in qView currently. If someone wants to implement this, just make a new action called "force delete" or something, absent from the context menu but present in the menubar, with a default keyboard shortcut of cmd/ctrl+del and for macOS cmd+option+backspace, or something along those lines. maybe you can add a modifier key to the QKeySequence::delete or something also.

@jurplel jurplel added the good first issue This is a good one to do if you want to contribute and don't have much experience label Aug 8, 2023
@jurplel jurplel added this to the qView 7.0 milestone Jan 12, 2024
@simonbcn
Copy link

I fully support this improvement. So deleting files on network drives would not be a problem.

@vassudanagunta
Copy link

We have a pull request that fixes this, #639, that's 18 months old. @jurplel not complaining, as i know you're busy and doing this for free. but i do think it impacts a lot of people, as new issues about this keep getting created.

@jurplel
Copy link
Owner

jurplel commented Apr 29, 2024

We have a pull request that fixes this, #639, that's 18 months old. @jurplel not complaining, as i know you're busy and doing this for free. but i do think it impacts a lot of people, as new issues about this keep getting created.

Yes, I absolutely need to merge it. I'm going to try to update qView again in a couple of weeks, but I am trying to coordinate a move during finals week right now.

@vassudanagunta
Copy link

good luck on your finals!

@illnesse
Copy link

illnesse commented May 3, 2024

oh cool i didn't see that PR, going to roll my own, thanks.
and good luck on your finals!

@simonbcn
Copy link

simonbcn commented May 7, 2024

Thanks. Will there be a release soon with this and other corrections?

@jurplel
Copy link
Owner

jurplel commented May 7, 2024

Gonna try to make a release soon, yes.

@peenstra
Copy link

Is there any progress on this issue? Or updates? Thanks!

@jurplel
Copy link
Owner

jurplel commented Sep 25, 2024

Sorry, still need to do this. I'll try to set some time aside for break in a couple weeks

@peenstra
Copy link

peenstra commented Nov 24, 2024

Sorry, still need to do this. I'll try to set some time aside for break in a couple weeks

Did you have any chance to do it =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue This is a good one to do if you want to contribute and don't have much experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants