Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move python/jupyterlab-chat to packages/ #165

Open
dlqqq opened this issue Feb 14, 2025 · 2 comments
Open

Move python/jupyterlab-chat to packages/ #165

dlqqq opened this issue Feb 14, 2025 · 2 comments
Labels
maintenance Packaging, tests

Comments

@dlqqq
Copy link
Member

dlqqq commented Feb 14, 2025

Problem

It's a little strange how python/jupyterlab-chat:

  • Shares a similar name to packages/jupyterlab-chat,
  • Refers to a NPM package of a different name (jupyterlab-chat-extension), and
  • Is under a different directory than the other extensions in this monorepo.

Proposed Solution

Move python/jupyterlab-chat to packages/jupyterlab-chat-extension.

Jupyter AI's monorepo structure allows for Python server extensions under packages/ as well. It uses a custom Jupyter Releaser configuration and Lerna scripts to build & release the packages.

Additional context

It would be nice to solve this issue to make it easier for new contributors to ramp up. However, this is a low priority issue given that it has no user impact.

@brichet Can you share more details about why the repo has a separate python/ folder, and if you think this issue makes sense?

@dlqqq dlqqq added the maintenance Packaging, tests label Feb 14, 2025
@dlqqq dlqqq changed the title Move python/jupyterlab-chat to packages/jupyterlab-chat-extension? Move python/jupyterlab-chat to packages/ Feb 14, 2025
@krassowski
Copy link
Member

I do like the separation between python and npm packages as in https://github.com/jupyterlab/jupyter-collaboration. I think it is much easier to reason about.

@brichet
Copy link
Collaborator

brichet commented Feb 14, 2025

Agree, maybe we should do like in jupyter-collaboration, keep only the python part in the python directory, and move jupyterlab-chat-extension in packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Packaging, tests
Projects
None yet
Development

No branches or pull requests

3 participants