'navigate files and folders with single click' only effective in jupyter lab

[zjqzero]

Description

upgrade to 7.3.1，'navigate files and folders with single click' not checked, but it's still affecting the behavior.

This option only effective in jupyter lab.

[andrii-i]

Hi @zjqzero. Thank you for creating this issue. I have tested this locally and I can't reproduce this with notebook 7.3.1 on M1 MacBook Pro macos 15.1.1 ('navigate files and folders with single click' is respected).

Could you please provide more information about the system and notebook version you are using?

- Operating System and version: <!-- e.g. Linux Ubuntu 21.04 -->
- Browser and version: <!-- e.g. Chrome 92 -->
<!-- Please note the Notebook version you are working with. You can find this in the Help -> About Jupyter Notebook menu option or by running `jupyter --version` from your terminal -->
- Jupyter Notebook version: <!-- e.g. 3.1.7 -->

[pythonic2020]

Using notebook 7.3.2 in a conda env on Win64 running Python 3.9, using only default notebook settings, I am getting the single-click behavior even though "Navigate files and directories with single click" setting is unchecked. This erroneous behavior is exactly that described by @zjqzero. There is also other bad behavior after closing a Firefox tab that contained an opened .ipynb file where the mouse cursor changes to a crossed-out circle with the filename of the .ipynb file just closed (see screenshot below). This bad cursor behavior disappears after clicking on notebook background.

If the "Navigate files and directories with single click" setting is checked and then unchecked, the behavior returns to normal.

This looks like a serious bug to me, but is probably not hard to fix.

[jtpio]

Thanks all for the report.

If the "Navigate files and directories with single click" setting is checked and then unchecked, the behavior returns to normal.

This can likely be the workaround for now.

Otherwise the issue mentioned above with files being dragged does seem to be easily reproducible indeed.

[jtpio]

The tricky part here is both JupyterLab and Jupyter Notebook use the same settings for the file browser widget, but not the same set of defaults.

Which explains why the checkbox is unchecked but the single click navigation enabled in Jupyter Notebook.

[miellaby]

@jtpio please note the single-click-causes-cursor-issue bug is worse than mentioned. In Firefox and Chrome, opening a file from the filebrowser (view single click mode) will open a new browser tab, but also hangs the filebrowser in drag&drop mode (this is the actual bug). When the end-user comes back to the filebrowser and clicks on a folder instead of the background, the filebrowser does move the opened file.

This bug is very annoying for non-techy users. I share locked-down jupyter notebooks with my coworkers as a form of rudimentary GUI, and they can't help but moving the configuration files in subfolders because of this bug.

[jtpio]

This bug is very annoying for non-techy users. I share locked-down jupyter notebooks with my coworkers as a form of rudimentary GUI, and they can't help but moving the configuration files in subfolders because of this bug.

The single-click open was added to Notebook 7 mostly to match the behavior of the classic notebook v6.

Ideally, we should switch back to having the same behavior in both JupyterLab and Notebook at some point. Personally I would be in favor of reverting back to double click to open files in new browser tabs, which would fix this issue. But it's not clear what other users think about this, and whether the prefer the single-click behavior.

[pythonic2020]

For what it's worth, I agree with @jtpio on reverting to double-click behavior for Notebook. That sounds like a simpler solution than fixing issues related to the addition of single-click functionality.

[jtpio]

If someone would like to open a PR to change the default, this is where is it currently defined:

notebook/packages/tree-extension/src/index.ts

Line 210 in 3edc44b

singleClickNavigation: true,

[jtpio]

FYI I opened #7624 to change the default.

If folks want to try it, you can use the Binder link for the PR: https://mybinder.org/v2/gh/jtpio/notebook/single-click-navigation-default?urlpath=tree