Skip to content

Commit 55d80f0

Browse files
hbcarlosfcollonval
andauthored
Improve IFactory API (#129)
* Improve IFactory API * Update javascript/src/api.ts Co-authored-by: Frédéric Collonval <[email protected]> Co-authored-by: Frédéric Collonval <[email protected]>
1 parent 42dd437 commit 55d80f0

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

javascript/src/api.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,10 @@ export type MapChanges = Map<
4747
export interface IFactory {
4848
/**
4949
* Create a new `ISharedDocument` instance.
50+
*
51+
* It should return `undefined` if the factory is not able to create a `ISharedDocument`.
5052
*/
51-
createNew(options: IFactory.IOptions): ISharedDocument;
53+
createNew(options: IFactory.IOptions): ISharedDocument | undefined;
5254
}
5355

5456
/**

yarn.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@
596596
"@jridgewell/sourcemap-codec" "1.4.14"
597597

598598
"@jupyter/ydoc@file:javascript":
599-
version "0.3.0-a2"
599+
version "0.3.0-a4"
600600
dependencies:
601601
"@jupyterlab/nbformat" "^3.0.0 || ^4.0.0-alpha.15"
602602
"@lumino/coreutils" "^1.11.0 || ^2.0.0-alpha.6"

0 commit comments

Comments
 (0)