Skip to content

Commit 3ac7277

Browse files
authored
Build images during release, capture release build/dist dirs (#1032)
It would be helpful to build the docker images during the release build. These will be pushed if the release is not in "dryRun", otherwise they remain on the local system. Previously, it was not sufficient to build the images from the release working directory because, after the release script has run, the dev versions are in place and extra care was required to get the proper kernelspecs included, etc. The script also "captures" the build and dist trees to the version-specific directory. This will more easily enable troubleshooting and "adjustments" to build artifacts (if necessary).
1 parent 06820bb commit 3ac7277

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Diff for: release.sh

+4-2
Original file line numberDiff line numberDiff line change
@@ -246,9 +246,9 @@ if [[ "$RELEASE_PREPARE" == "true" ]]; then
246246

247247
cd $SOURCE_DIR
248248
if [ -z "$DRY_RUN" ]; then
249-
make clean dist release docs
249+
make clean dist release docs docker-images push-images
250250
else
251-
make clean dist docs
251+
make clean dist docs docker-images
252252
fi
253253
mkdir -p $WORK_DIR/$RELEASE_TAG
254254
cp $SOURCE_DIR/dist/jupyter_enterprise_gateway* $WORK_DIR/$RELEASE_TAG
@@ -260,6 +260,8 @@ if [[ "$RELEASE_PREPARE" == "true" ]]; then
260260
update_version_to_development
261261

262262
cd $SOURCE_DIR
263+
mv dist $WORK_DIR/$RELEASE_TAG
264+
mv build $WORK_DIR/$RELEASE_TAG
263265
make clean dist docs
264266

265267
# Build next development iteraction

0 commit comments

Comments
 (0)