Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The enricher doesn't work if there's no cid or uid claims #4

Open
montoner0 opened this issue Nov 1, 2024 · 2 comments
Open

The enricher doesn't work if there's no cid or uid claims #4

montoner0 opened this issue Nov 1, 2024 · 2 comments

Comments

@montoner0
Copy link

Since the enricher checks only specific claims it won't work for any other cases (e. g. OAuth). It would be better to try Identity.Name before checking for claims. I can make a PR with a fix if you're interested.

@rafaelpadovezi
Copy link
Member

Hi @montoner0, this enricher was tailor made for our use case but we are open to improve and provide a better solution for the community.
Why do you believe Identity.Nameis a better fit? An issue with using the name is that normally we avoid logging user information this way.

@montoner0
Copy link
Author

I think the Identity.Name is a more standard way to get user's ID since it's present in most cases, and better to have some ID than not to have any. But if you think that's against some security considerations then I won't insist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants