Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import LivingCookbook: read more fields #1227

Open
xaviermiller opened this issue Jan 4, 2024 · 4 comments
Open

Import LivingCookbook: read more fields #1227

xaviermiller opened this issue Jan 4, 2024 · 4 comments
Assignees
Labels
feature New feature or request

Comments

@xaviermiller
Copy link

xaviermiller commented Jan 4, 2024

Is your new feature related to a problem? Please describe.
The FDX import read almost everything except CookBook/CookbokChapter, RecipeReview tags
And BMP images are not imported because BMP is not supported by RecipeSage

Describe the solution you'd like
Add CookBook / CookbookChapter text to recipe labels
Add RecipeReview to recipe notes + rating
Provide message when an image is not imported (BMP). See also #1226

Describe alternatives you've considered
N/A

Additional context
I will try to see if I could code that and propose a PR

@xaviermiller xaviermiller added the feature New feature or request label Jan 4, 2024
@julianpoy
Copy link
Owner

Would welcome a PR! Living Cookbook format is notoriously hard to deal with, but everything should be available after this line via tableMap https://github.com/julianpoy/RecipeSage/blob/master/packages/backend/src/lcbimport.app.js#L231. Please note that all of the LCB import code is quite old and kinda hard to work with & test.

@xaviermiller
Copy link
Author

OK, I will work only on FDX(z) format. LCB will be ignored, I have all my LCB database exported to FDX. And there is a tool to export LCB DB/Backup to FDX, MM.

How can I simply test it? I would see the results while I am changing the code

@julianpoy
Copy link
Owner

You'll need to setup a development environment, see here:

https://github.com/julianpoy/RecipeSage#development

@xaviermiller
Copy link
Author

OK thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants