Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apostrophe imported incorrectly #75

Closed
mudnug opened this issue Aug 26, 2024 · 8 comments
Closed

Apostrophe imported incorrectly #75

mudnug opened this issue Aug 26, 2024 · 8 comments

Comments

@mudnug
Copy link

mudnug commented Aug 26, 2024

Clip https://recipes.heart.org/en/recipes/hoppin-john

Expected:
Hoppin' John

Actual:
Hoppin' John

@mudnug
Copy link
Author

mudnug commented Aug 26, 2024

I'm not actually sure if this is an issue with Recipesage or with the clipper.

@mudnug
Copy link
Author

mudnug commented Sep 15, 2024

Another example. Try to import https://www.food.com/recipe/bangkok-chicken-curry-476986 with RecipeSage
Expected:
"If you’ve ever wanted to make Thai food at home, you have to try this! It’s a great “impress your friends” dish."
Actual:
If you’ve ever wanted to make Thai food at home, you have to try this! It’s a great “impress your friends” dish.

@julianpoy
Copy link
Owner

Not related to RecipeClipper

@julianpoy julianpoy closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2025
@julianpoy
Copy link
Owner

julianpoy commented Feb 9, 2025

(I believe this should be solved by now in RecipeSage)

@mudnug
Copy link
Author

mudnug commented Feb 10, 2025

I tried importing just now and still get the unexpected behavior. How do I determine if something is an issue with RecipeClipper vs RecipeSage? I thought these were with the former. Do youw ant them recreated against RecipeSage?

@julianpoy
Copy link
Owner

julianpoy commented Feb 10, 2025

All issues should be opened against RecipeSage unless interacting directly with this package as a developer. This is a package published to NPM and happens to be a dependency of RecipeSage the app.

@mudnug
Copy link
Author

mudnug commented Feb 10, 2025

Ok, that might be handy to add to somewhere to this repo so others know. (I thought you wanted the issues filed here if the bugs would likely need to be fixed here because they occurred across all platforms.)

@julianpoy
Copy link
Owner

No worries - This package is developer oriented. I'd just prefer to field import compat issues there, but I guess this is fine regardless. Will take a look at the issue and see if I can figure out what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants