Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails when pulling multi-part recipe #72

Closed
mudnug opened this issue Aug 25, 2024 · 3 comments
Closed

Fails when pulling multi-part recipe #72

mudnug opened this issue Aug 25, 2024 · 3 comments

Comments

@mudnug
Copy link

mudnug commented Aug 25, 2024

When a recipe includes ingredients and instructions for an item as well as additional ingredients and instructions for an additional part like a glaze, the code performs poorly missing instructions and ingredients.

E.g., Used https://www.theoldhen.com/glazed-pecan-danish/

I'm not sure whether this would be a defect or a feature situation; whether the ingredients should be combined into one list will need to be decided, but my preference is 2 ingredient lists as this avoids issues when the same ingredient is used in both parts of the recipe.

I noticed https://www.tasteofhome.com/recipes/zucchini-apple-crisp/ is parsed correctly, This site has the directions one after another instead of ingredients 1, directions 1, and more ingredients 2 and then more directions 2.

@mudnug mudnug changed the title Fails when pulling multi-part recipie Fails when pulling multi-part recipe Aug 25, 2024
@mudnug
Copy link
Author

mudnug commented Aug 25, 2024

Perhaps a new import mode ("Clip Multi-part recipe") is needed?

@mudnug
Copy link
Author

mudnug commented Oct 14, 2024

@julianpoy
Copy link
Owner

julianpoy commented Feb 14, 2025

Couple of issues with TheOldHen - it has relatively no classnames, and is mostly just a text document so will fall back to ML. Multiple recipes is also not supported within a single clip.

This is definitely a situation where I'd recommend using the clip browser extension, since it allows manual selection of parts of the page. As it stands, pulling multiple recipes from a single site is going to be outside of the scope of this package unfortunately :/

@julianpoy julianpoy closed this as not planned Won't fix, can't repro, duplicate, stale Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants