Skip to content

Commit ca915ff

Browse files
committed
Make resolve_client private.
1 parent c98e077 commit ca915ff

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

src/judge0/api.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def get_client(flavor: Flavor = Flavor.CE) -> Client:
2020
)
2121

2222

23-
def resolve_client(
23+
def _resolve_client(
2424
client: Optional[Union[Client, Flavor]] = None,
2525
submissions: Optional[Union[Submission, Submissions]] = None,
2626
) -> Client:
@@ -60,7 +60,7 @@ def create_submissions(
6060
client: Optional[Client] = None,
6161
submissions: Optional[Union[Submission, Submissions]] = None,
6262
) -> Union[Submission, Submissions]:
63-
client = resolve_client(client=client, submissions=submissions)
63+
client = _resolve_client(client=client, submissions=submissions)
6464

6565
if isinstance(submissions, Submission):
6666
return client.create_submission(submissions)
@@ -83,7 +83,7 @@ def get_submissions(
8383
submissions: Optional[Union[Submission, Submissions]] = None,
8484
fields: Union[str, Iterable[str], None] = None,
8585
) -> Union[Submission, Submissions]:
86-
client = resolve_client(client=client, submissions=submissions)
86+
client = _resolve_client(client=client, submissions=submissions)
8787

8888
if isinstance(submissions, Submission):
8989
return client.get_submission(submissions, fields=fields)
@@ -110,7 +110,7 @@ def wait(
110110
submissions: Optional[Union[Submission, Submissions]] = None,
111111
retry_mechanism: Optional[RetryMechanism] = None,
112112
) -> Union[Submission, Submissions]:
113-
client = resolve_client(client, submissions)
113+
client = _resolve_client(client, submissions)
114114

115115
if retry_mechanism is None:
116116
retry_mechanism = RegularPeriodRetry()
@@ -207,7 +207,7 @@ def _execute(
207207
if source_code is not None:
208208
submissions = Submission(source_code=source_code, **kwargs)
209209

210-
client = resolve_client(client=client, submissions=submissions)
210+
client = _resolve_client(client=client, submissions=submissions)
211211
all_submissions = create_submissions_from_test_cases(submissions, test_cases)
212212
all_submissions = create_submissions(client=client, submissions=all_submissions)
213213

tests/test_api.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import pytest
33

44
from judge0 import Flavor, LanguageAlias, Submission
5-
from judge0.api import resolve_client
5+
from judge0.api import _resolve_client
66

77
DEFAULT_CLIENTS = (
88
"atd_ce_client",
@@ -17,7 +17,7 @@
1717
@pytest.mark.parametrize("client", DEFAULT_CLIENTS)
1818
def test_resolve_client_with_explicit_client(client, request):
1919
client = request.getfixturevalue(client)
20-
assert resolve_client(client) is client
20+
assert _resolve_client(client) is client
2121

2222

2323
@pytest.mark.parametrize(
@@ -38,7 +38,7 @@ def test_resolve_client_with_flavor(
3838
expected_client,
3939
):
4040
# We have to use getattr since both implicit clients are initially None.
41-
assert resolve_client(client=flavor) is getattr(judge0, expected_client)
41+
assert _resolve_client(client=flavor) is getattr(judge0, expected_client)
4242

4343

4444
@pytest.mark.parametrize(
@@ -51,7 +51,7 @@ def test_resolve_client_with_flavor(
5151
@pytest.mark.skip
5252
def test_resolve_client_empty_submissions_argument(submissions):
5353
with pytest.raises(ValueError):
54-
resolve_client(submissions=submissions)
54+
_resolve_client(submissions=submissions)
5555

5656

5757
def test_resolve_client_no_common_client_for_submissions():
@@ -68,7 +68,7 @@ def test_resolve_client_no_common_client_for_submissions():
6868
submissions = [cpp_submission, py_submission]
6969

7070
with pytest.raises(RuntimeError):
71-
resolve_client(submissions=submissions)
71+
_resolve_client(submissions=submissions)
7272

7373

7474
def test_resolve_client_common_ce_client():
@@ -84,7 +84,7 @@ def test_resolve_client_common_ce_client():
8484

8585
submissions = [cpp_submission, py_submission]
8686

87-
assert resolve_client(submissions=submissions) is judge0.JUDGE0_IMPLICIT_CE_CLIENT
87+
assert _resolve_client(submissions=submissions) is judge0.JUDGE0_IMPLICIT_CE_CLIENT
8888

8989

9090
def test_resolve_client_common_extra_ce_client():
@@ -101,6 +101,6 @@ def test_resolve_client_common_extra_ce_client():
101101
submissions = [cpp_submission, py_submission]
102102

103103
assert (
104-
resolve_client(submissions=submissions)
104+
_resolve_client(submissions=submissions)
105105
is judge0.JUDGE0_IMPLICIT_EXTRA_CE_CLIENT
106106
)

0 commit comments

Comments
 (0)