Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class detection for filter preview #3

Open
r3cla opened this issue Jan 10, 2025 · 4 comments
Open

Class detection for filter preview #3

r3cla opened this issue Jan 10, 2025 · 4 comments

Comments

@r3cla
Copy link
Contributor

r3cla commented Jan 10, 2025

Hey! Was just mucking around with your app when I noticed it doesn't seem to like Class rules very much. Unless I'm not understanding how filters work exactly, I think this should target all Life Flasks right?

Doesnt work:

Show 
    Class Life Flasks
    SetTextColor 255 255 255 255

Works:

Show
    BaseType "Ultimate Life Flask"
    SetTextColor 255 255 255 255

Also doesn't work:

Show
    Class Life Flasks
    BaseType "Ultimate Life Flask"
    SetTextColor 255 255 255 255
@juddisjudd
Copy link
Owner

Needs quotes for the class since it's 2 words

@juddisjudd
Copy link
Owner

juddisjudd commented Jan 10, 2025

But also there are a few cases the image preview might not work. Class actually is probably one of them. Still working on the parser. This is is the file that needs a lot of work on:
https://github.com/juddisjudd/poe2-filter-editor/blob/master/src/utils/filterParser.ts

Much to consider as so many people approach their rules differently.

@r3cla
Copy link
Contributor Author

r3cla commented Jan 10, 2025

Much to consider as so many people approach their rules differently.

I know right, every time I upload or reference a different filter, they're doing something slightly different in it.

I'll have a look later today and see if I can help.

@juddisjudd
Copy link
Owner

Much to consider as so many people approach their rules differently.

I know right, every time I upload or reference a different filter, they're doing something slightly different in it.

I'll have a look later today and see if I can help.

Much appreciated.

Here is probably one of the more complicated ones that I am currently trying to make sure works as solid as possible.
https://github.com/cdrg/cdr-poe2filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants