Preparation code output script stripping is incomplete

[Chessax]

As far as I understand according to #228 the preparation code output should be stripped of any and all <script> tags, yet it only strips the first script tag it finds. This is due to String.prototype.replace() stopping after the first match unless a RegExp with the global flag is used.

However due to #236, being unable to edit tests, I can't really give any neat live examples.

Regex definition is here:

jsperf.com/server/lib/regex.js

Line 88 in f61045f

script: '(<script[^>]*?>)([\\s\\S]*?)(</script>)'

RegEx instantiation and replacing is here:

jsperf.com/server/web/test/index.js

Lines 26 to 27 in f61045f

	const reScripts = new RegExp(regex.script, 'i');
	stripped = page.initHTML.replace(reScripts, '');

I.e. this RegEx():

const reScripts = new RegExp(regex.script, 'i');

Should have the global (g) flag as well:

const reScripts = new RegExp(regex.script, 'ig');

These lines will also be affected (a good thing):

jsperf.com/server/web/test/index.js

Lines 33 to 34 in f61045f

	page.initHTML.replace(
	reScripts,

And last but not least, this line should have the global flag as well, for the same reasons:

jsperf.com/server/web/test/index.js

Line 45 in f61045f

).value.replace(/@jsPerfTagToken/, () => swappedScripts.pop());

As a side note; highlight.js 9.12.0 (and apparently the version used in jsPerf) automatically highlights javascript inside HTML-code, so the special code for swapping for @jsPerfTagToken back and forth is not really required (though I guess it doesn't really hurt). This is also the reason the code "works", because highlight.js is masking the fact that only the content of the first <script> tag is explicitly highlighted.

[mathiasbynens]

Would you be willing to submit a PR? You’ve done all the hard work already :) (Much appreciated!)