Skip to content

Commit ea1e63e

Browse files
committed
Flash of content fix
Feels a bit hacky, but seems to work ok, will need to test with ng1.5 before release.
1 parent 016693a commit ea1e63e

7 files changed

+28
-10
lines changed

CHANGELOG

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,24 @@
1-
v1.0.0-alpha.2
1+
v1.0.0-alpha.3
22
--------------
3-
This is the second (of many) alpha and is **NOT ready for production** yet.
3+
This is the third (of many) alpha and is **NOT ready for production** yet.
4+
5+
This alpha fixes a few bugs like the annoying "Invalid type, expected array" error when an array content is invalid.
6+
7+
## Known issues
8+
- In Angular 1.5+ some odd behaviours can occur if refreshing a form with a flash of content experienced
9+
The digest cycle is getting stuck under some unknown conditions which is most likely related
10+
11+
## Changes
12+
13+
### Fixed
14+
- Arrays update validity more consistently, removed Angular version specific code
15+
- Add-ons will now correctly display by the added type being passed to the core correctly
16+
- #750 Unstoppable "Invalid type, expected array" when form initialised with incorrect array content.
17+
- #633 #602 custom validator errors.
18+
- #558 Add check for schema property to prevent form generation failures when a checkbox is explicitly defined by a developer (and therefore does not have a schema property) by @vinceis1337 in #663
419

20+
v1.0.0-alpha.2
21+
--------------
522
There is only one change in this alpha that needs user testing and feedback, the long awaited and much desired support for $ref.
623

724
## Changes

bower.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
"angular-schema-form-tinymce": "^0.1.0"
5757
},
5858
"resolutions": {
59-
"jquery": "~2.1.1"
59+
"jquery": "~2.1.1",
60+
"angular": "1.3"
6061
}
6162
}

dist/angular-schema-form-bootstrap.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/*!
22
* angular-schema-form
33
* @version 1.0.0-alpha.3
4-
* @date Mon, 27 Mar 2017 13:17:01 GMT
4+
* @date Thu, 30 Mar 2017 07:57:38 GMT
55
* @link https://github.com/json-schema-form/angular-schema-form
66
* @license MIT
77
* Copyright (c) 2014-2017 JSON Schema Form

dist/angular-schema-form-bootstrap.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/angular-schema-form.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/*!
22
* angular-schema-form
33
* @version 1.0.0-alpha.3
4-
* @date Mon, 27 Mar 2017 13:17:01 GMT
4+
* @date Thu, 30 Mar 2017 07:57:38 GMT
55
* @link https://github.com/json-schema-form/angular-schema-form
66
* @license MIT
77
* Copyright (c) 2014-2017 JSON Schema Form
@@ -3861,8 +3861,6 @@ FIXME: real documentation
38613861
};
38623862

38633863
scope.render = function (schema, form) {
3864-
//console.log("schema:", JSON.stringify(schema));
3865-
//console.log("resolv:", JSON.stringify(resolved));
38663864
var asyncTemplates = [];
38673865
var merged = schemaForm.merge(schema, form, undefined, ignore, scope.options, undefined, asyncTemplates);
38683866

@@ -3926,6 +3924,7 @@ FIXME: real documentation
39263924
// We use a ordinary timeout since we don't need a digest after this.
39273925
setTimeout(function () {
39283926
childScope.firstDigest = false;
3927+
scope.$apply();
39293928
}, 0);
39303929

39313930
//compile only children

dist/angular-schema-form.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/directives/sf-schema.directive.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ sfSelect, sfPath, sfBuilder) {
154154
// We use a ordinary timeout since we don't need a digest after this.
155155
setTimeout(function() {
156156
childScope.firstDigest = false;
157+
scope.$apply();
157158
}, 0);
158159

159160
//compile only children

0 commit comments

Comments
 (0)