Fix new warnings

Author: bkoelman

src/Examples/DapperExample/TranslationToSql/TreeNodes/TableSourceNode.cs

@@ -7,7 +7,7 @@ namespace DapperExample.TranslationToSql.TreeNodes;
 /// </summary>
 internal abstract class TableSourceNode(string? alias) : SqlTreeNode
 {
-    public const string IdColumnName = nameof(Identifiable<object>.Id);
+    public const string IdColumnName = nameof(Identifiable<>.Id);
 
     public abstract IReadOnlyList<ColumnNode> Columns { get; }
     public string? Alias { get; } = alias;

src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiActionDescriptorCollectionProvider.cs

@@ -315,7 +315,7 @@ private static void SetConsumes(ActionDescriptor descriptor, Type requestType, J
         string contentType = mediaType.ToString();
 
         if (descriptor is ControllerActionDescriptor controllerActionDescriptor &&
-            controllerActionDescriptor.MethodInfo.GetCustomAttributes(typeof(ConsumesAttribute)).Any())
+            controllerActionDescriptor.MethodInfo.GetCustomAttributes<ConsumesAttribute>().Any())
         {
             // A custom JSON:API action method with [Consumes] on it. Hide the attribute from Swashbuckle, so it uses our data in API Explorer.
             controllerActionDescriptor.MethodInfo = new MethodInfoWrapper(controllerActionDescriptor.MethodInfo, [typeof(ConsumesAttribute)]);

src/JsonApiDotNetCore.OpenApi.Swashbuckle/SwaggerComponents/DocumentationOpenApiOperationFilter.cs

@@ -5,7 +5,6 @@
 using JsonApiDotNetCore.Controllers;
 using JsonApiDotNetCore.Middleware;
 using JsonApiDotNetCore.OpenApi.Swashbuckle.JsonApiMetadata.ActionMethods;
-using JsonApiDotNetCore.Resources;
 using JsonApiDotNetCore.Resources.Annotations;
 using Microsoft.AspNetCore.Mvc.ApiExplorer;
 using Microsoft.Net.Http.Headers;
@@ -19,15 +18,15 @@ namespace JsonApiDotNetCore.OpenApi.Swashbuckle.SwaggerComponents;
 [UsedImplicitly(ImplicitUseKindFlags.InstantiatedNoFixedConstructorSignature)]
 internal sealed class DocumentationOpenApiOperationFilter : IOperationFilter
 {
-    private const string GetPrimaryName = nameof(BaseJsonApiController<Identifiable<int>, int>.GetAsync);
-    private const string GetSecondaryName = nameof(BaseJsonApiController<Identifiable<int>, int>.GetSecondaryAsync);
-    private const string GetRelationshipName = nameof(BaseJsonApiController<Identifiable<int>, int>.GetRelationshipAsync);
-    private const string PostResourceName = nameof(BaseJsonApiController<Identifiable<int>, int>.PostAsync);
-    private const string PostRelationshipName = nameof(BaseJsonApiController<Identifiable<int>, int>.PostRelationshipAsync);
-    private const string PatchResourceName = nameof(BaseJsonApiController<Identifiable<int>, int>.PatchAsync);
-    private const string PatchRelationshipName = nameof(BaseJsonApiController<Identifiable<int>, int>.PatchRelationshipAsync);
-    private const string DeleteResourceName = nameof(BaseJsonApiController<Identifiable<int>, int>.DeleteAsync);
-    private const string DeleteRelationshipName = nameof(BaseJsonApiController<Identifiable<int>, int>.DeleteRelationshipAsync);
+    private const string GetPrimaryName = nameof(BaseJsonApiController<,>.GetAsync);
+    private const string GetSecondaryName = nameof(BaseJsonApiController<,>.GetSecondaryAsync);
+    private const string GetRelationshipName = nameof(BaseJsonApiController<,>.GetRelationshipAsync);
+    private const string PostResourceName = nameof(BaseJsonApiController<,>.PostAsync);
+    private const string PostRelationshipName = nameof(BaseJsonApiController<,>.PostRelationshipAsync);
+    private const string PatchResourceName = nameof(BaseJsonApiController<,>.PatchAsync);
+    private const string PatchRelationshipName = nameof(BaseJsonApiController<,>.PatchRelationshipAsync);
+    private const string DeleteResourceName = nameof(BaseJsonApiController<,>.DeleteAsync);
+    private const string DeleteRelationshipName = nameof(BaseJsonApiController<,>.DeleteRelationshipAsync);
     private const string PostOperationsName = nameof(BaseJsonApiOperationsController.PostOperationsAsync);
 
     private const string TextCompareETag =

src/JsonApiDotNetCore.OpenApi.Swashbuckle/SwaggerComponents/JsonApiDataContractResolver.cs

@@ -63,7 +63,7 @@ private List<DataProperty> GetDataPropertiesThatExistInResourceClrType(Type reso
 
         foreach (DataProperty? property in dataContract.ObjectProperties)
         {
-            if (property.MemberInfo.Name == nameof(Identifiable<object>.Id))
+            if (property.MemberInfo.Name == nameof(Identifiable<>.Id))
             {
                 // Schemas of JsonApiDotNetCore resources will obtain an Id property through inheritance of a resource identifier type.
                 continue;

src/JsonApiDotNetCore/Configuration/IJsonApiOptions.cs

@@ -175,6 +175,8 @@ public interface IJsonApiOptions
     /// </summary>
     IsolationLevel? TransactionIsolationLevel { get; }
 
+    // ReSharper disable once InvalidXmlDocComment
+    // Justification: Temporary workaround for Resharper bug at https://youtrack.jetbrains.com/issue/RSRP-501671.
     /// <summary>
     /// Lists the JSON:API extensions that are turned on. Empty by default, but if your project contains a controller that derives from
     /// <see cref="BaseJsonApiOperationsController" />, the <see cref="JsonApiMediaTypeExtension.AtomicOperations" /> and

src/JsonApiDotNetCore/Configuration/JsonApiValidationFilter.cs

@@ -61,7 +61,7 @@ private IServiceProvider GetScopedServiceProvider()
 
     private static bool IsId(string key)
     {
-        return key == nameof(Identifiable<object>.Id) || key.EndsWith($".{nameof(Identifiable<object>.Id)}", StringComparison.Ordinal);
+        return key == nameof(Identifiable<>.Id) || key.EndsWith($".{nameof(Identifiable<>.Id)}", StringComparison.Ordinal);
     }
 
     private static bool IsAtPrimaryEndpoint(IJsonApiRequest request)

src/JsonApiDotNetCore/Configuration/ResourceGraphBuilder.cs

@@ -299,7 +299,7 @@ private Dictionary<string, AttrAttribute>.ValueCollection GetAttributes(Type res
 
             if (attribute == null)
             {
-                if (property.Name == nameof(Identifiable<object>.Id))
+                if (property.Name == nameof(Identifiable<>.Id))
                 {
                     // Although strictly not correct, 'id' is added to the list of attributes for convenience.
                     // For example, it enables to filter on ID, without the need to special-case existing logic.

src/JsonApiDotNetCore/Errors/InvalidModelStateException.cs

@@ -134,7 +134,7 @@ private static List<ErrorObject> FromModelStateDictionary(IReadOnlyDictionary<st
 
     private static string? ResolveSourcePointerInAttribute(PropertySegment segment, AttrAttribute attribute, IResourceGraph resourceGraph)
     {
-        string sourcePointer = attribute.Property.Name == nameof(Identifiable<object>.Id)
+        string sourcePointer = attribute.Property.Name == nameof(Identifiable<>.Id)
             ? $"{segment.SourcePointer ?? "/data"}/{attribute.PublicName}"
             : $"{segment.SourcePointer ?? "/data"}/attributes/{attribute.PublicName}";
 

src/JsonApiDotNetCore/Queries/Parsing/FilterParser.cs

@@ -539,7 +539,7 @@ protected virtual ConstantValueConverter GetConstantValueConverterForType(Type d
 
     private ConstantValueConverter GetConstantValueConverterForAttribute(AttrAttribute attribute)
     {
-        if (attribute is { Property.Name: nameof(Identifiable<object>.Id) })
+        if (attribute is { Property.Name: nameof(Identifiable<>.Id) })
         {
             return (stringValue, position) =>
             {

src/JsonApiDotNetCore/Queries/QueryLayerComposer.cs

@@ -620,6 +620,6 @@ protected virtual PaginationExpression GetPagination(IReadOnlyCollection<QueryEx
 
     private static AttrAttribute GetIdAttribute(ResourceType resourceType)
     {
-        return resourceType.GetAttributeByPropertyName(nameof(Identifiable<object>.Id));
+        return resourceType.GetAttributeByPropertyName(nameof(Identifiable<>.Id));
     }
 }