Skip to content

Commit 2b9f6ae

Browse files
author
Bart Koelman
committed
Removed unused dependency on IResourceFactory from JsonApiResourceService
1 parent 507f90c commit 2b9f6ae

File tree

4 files changed

+4
-11
lines changed

4 files changed

+4
-11
lines changed

docs/usage/extensibility/services.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,9 @@ public class TodoItemService : JsonApiResourceService<TodoItem>
2323
ILoggerFactory loggerFactory,
2424
IJsonApiRequest request,
2525
IResourceChangeTracker<TodoItem> resourceChangeTracker,
26-
IResourceFactory resourceFactory,
2726
IResourceHookExecutorFacade hookExecutor)
2827
: base(repositoryAccessor, queryLayerComposer, paginationContext, options, loggerFactory,
29-
request, resourceChangeTracker, resourceFactory, hookExecutor)
28+
request, resourceChangeTracker, hookExecutor)
3029
{
3130
_notificationService = notificationService;
3231
}

src/Examples/JsonApiDotNetCoreExample/Services/CustomArticleService.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,9 @@ public CustomArticleService(
2222
ILoggerFactory loggerFactory,
2323
IJsonApiRequest request,
2424
IResourceChangeTracker<Article> resourceChangeTracker,
25-
IResourceFactory resourceFactory,
2625
IResourceHookExecutorFacade hookExecutor)
2726
: base(repositoryAccessor, queryLayerComposer, paginationContext, options, loggerFactory, request,
28-
resourceChangeTracker, resourceFactory, hookExecutor)
27+
resourceChangeTracker, hookExecutor)
2928
{ }
3029

3130
public override async Task<Article> GetAsync(int id, CancellationToken cancellationToken)

src/JsonApiDotNetCore/Services/JsonApiResourceService.cs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ public class JsonApiResourceService<TResource, TId> :
3030
private readonly TraceLogWriter<JsonApiResourceService<TResource, TId>> _traceWriter;
3131
private readonly IJsonApiRequest _request;
3232
private readonly IResourceChangeTracker<TResource> _resourceChangeTracker;
33-
private readonly IResourceFactory _resourceFactory;
3433
private readonly IResourceHookExecutorFacade _hookExecutor;
3534

3635
public JsonApiResourceService(
@@ -41,7 +40,6 @@ public JsonApiResourceService(
4140
ILoggerFactory loggerFactory,
4241
IJsonApiRequest request,
4342
IResourceChangeTracker<TResource> resourceChangeTracker,
44-
IResourceFactory resourceFactory,
4543
IResourceHookExecutorFacade hookExecutor)
4644
{
4745
if (loggerFactory == null) throw new ArgumentNullException(nameof(loggerFactory));
@@ -53,7 +51,6 @@ public JsonApiResourceService(
5351
_traceWriter = new TraceLogWriter<JsonApiResourceService<TResource, TId>>(loggerFactory);
5452
_request = request ?? throw new ArgumentNullException(nameof(request));
5553
_resourceChangeTracker = resourceChangeTracker ?? throw new ArgumentNullException(nameof(resourceChangeTracker));
56-
_resourceFactory = resourceFactory ?? throw new ArgumentNullException(nameof(resourceFactory));
5754
_hookExecutor = hookExecutor ?? throw new ArgumentNullException(nameof(hookExecutor));
5855
}
5956

@@ -469,10 +466,9 @@ public JsonApiResourceService(
469466
ILoggerFactory loggerFactory,
470467
IJsonApiRequest request,
471468
IResourceChangeTracker<TResource> resourceChangeTracker,
472-
IResourceFactory resourceFactory,
473469
IResourceHookExecutorFacade hookExecutor)
474470
: base(repositoryAccessor, queryLayerComposer, paginationContext, options, loggerFactory, request,
475-
resourceChangeTracker, resourceFactory, hookExecutor)
471+
resourceChangeTracker, hookExecutor)
476472
{
477473
}
478474
}

test/DiscoveryTests/ServiceDiscoveryFacadeTests.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,10 +155,9 @@ public TestModelService(
155155
ILoggerFactory loggerFactory,
156156
IJsonApiRequest request,
157157
IResourceChangeTracker<TestModel> resourceChangeTracker,
158-
IResourceFactory resourceFactory,
159158
IResourceHookExecutorFacade hookExecutor)
160159
: base(repositoryAccessor, queryLayerComposer, paginationContext, options, loggerFactory, request,
161-
resourceChangeTracker, resourceFactory, hookExecutor)
160+
resourceChangeTracker, hookExecutor)
162161
{
163162
}
164163
}

0 commit comments

Comments
 (0)