Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to skip mandatory token #18

Open
ThomasG77 opened this issue Nov 24, 2017 · 1 comment
Open

Provide an option to skip mandatory token #18

ThomasG77 opened this issue Nov 24, 2017 · 1 comment

Comments

@ThomasG77
Copy link

ThomasG77 commented Nov 24, 2017

I've made a Node/Express based server (mentioned in #16 (comment)) to replace the current Mapbox Markers API.

If I want to consume the server with your plugin, I need to fork it due to the mandatory token https://github.com/jseppi/Leaflet.MakiMarkers/blob/master/Leaflet.MakiMarkers.js#L60

Can you provide in the option a way to avoid it. A parameter like skipAccessToken with default value to false could do the job. I can make a PR if you agree on the principle & the approach.

@jseppi
Copy link
Owner

jseppi commented Nov 28, 2017

Sure, please do submit a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants