[refactor] no need to flush again, we just did it

kares · kares · commit 68d4c2f09b1e · 2022-07-02T14:08:21.000+02:00
diff --git a/src/main/java/org/jruby/ext/openssl/SSLSocket.java b/src/main/java/org/jruby/ext/openssl/SSLSocket.java
@@ -591,7 +591,7 @@ private IRubyObject doHandshake(final boolean blocking, final boolean exception)
                     netWriteData.compact();
                     netWriteData = Utils.ensureCapacity(netWriteData, engine.getSession().getPacketBufferSize());
                     netWriteData.flip();
-                    if (handshakeStatus != SSLEngineResult.HandshakeStatus.NEED_UNWRAP || flushData(blocking)) {
+                    if (handshakeStatus != SSLEngineResult.HandshakeStatus.NEED_UNWRAP) {
                         sel = waitSelect(SelectionKey.OP_WRITE, blocking, exception);
                         if ( sel instanceof IRubyObject ) return (IRubyObject) sel; // :wait_writeable
                     }

Original file line number	Diff line number	Diff line change
`@@ -591,7 +591,7 @@ private IRubyObject doHandshake(final boolean blocking, final boolean exception)`
`591`	`591`	`netWriteData.compact();`
`592`	`592`	`netWriteData = Utils.ensureCapacity(netWriteData, engine.getSession().getPacketBufferSize());`
`593`	`593`	`netWriteData.flip();`
`594`		`- if (handshakeStatus != SSLEngineResult.HandshakeStatus.NEED_UNWRAP \|\| flushData(blocking)) {`
	`594`	`+ if (handshakeStatus != SSLEngineResult.HandshakeStatus.NEED_UNWRAP) {`
`595`	`595`	`sel = waitSelect(SelectionKey.OP_WRITE, blocking, exception);`
`596`	`596`	`if ( sel instanceof IRubyObject ) return (IRubyObject) sel; // :wait_writeable`
`597`	`597`	`}`