Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CI Pipeline Failing on missing SPI.h File #102

Open
2 tasks done
Arribe opened this issue Apr 2, 2024 · 4 comments
Open
2 tasks done

[Bug]: CI Pipeline Failing on missing SPI.h File #102

Arribe opened this issue Apr 2, 2024 · 4 comments
Labels
Category: Library This issue affects an embedded library other than DCS-BIOS. P2 High Priority: This is the defect or issue which should be resolved before the release is made. Thes S2 Major Severity: Any Major feature implemented that is not meeting its requirements/use case(s) and b Type: Bug Something is not working as expected.
Milestone

Comments

@Arribe
Copy link
Collaborator

Arribe commented Apr 2, 2024

Discord Username

Arribe

Bug Summary

PR #101 is failing with entry: /home/runner/work/OpenHornet-Software/OpenHornet-Software/libraries/Arduino-FOC-drivers/src/encoders/mt6835/./MT6835.h:8:10: fatal error: SPI.h: No such file or directory
8 | #include "SPI.h"
| ^~~~~~~
compilation terminated.

Expected Results

The sketch should compile as SPI.h is a base library included with all Arduino platforms.

Actual Results

The CI fails to complete with the error the SPI.h file is missing. I even tried including it at the top of the include list on the main sketch.

Screenshots/Images/Files

image

Applicable File Names

PR 4A9A1-THROTTLE_CONTROLLER.ino #101

Release Version

v0.3.0

Category

Libraries & Dependencies (Arduino Libraries, etc)

Applicable End Item(s)

Throttle

Hardware is built to print & this software is tested on that hardware?

  • I built (or attempted to build) the part to the OpenHornet print without any deviations and tested the software on it.
  • I am not building this part to the OH print. (List deviations in detail in the Miscellaneous Info text area below.)

Miscellaneous Info

No response

@Arribe Arribe added the Triage Required This item still requires triage by a repository administrator. label Apr 2, 2024
@jrsteensen jrsteensen added Type: Bug Something is not working as expected. Category: Library This issue affects an embedded library other than DCS-BIOS. P2 High Priority: This is the defect or issue which should be resolved before the release is made. Thes S2 Major Severity: Any Major feature implemented that is not meeting its requirements/use case(s) and b and removed Triage Required This item still requires triage by a repository administrator. labels Apr 4, 2024
@jrsteensen jrsteensen added this to the v0.1.0 milestone Apr 4, 2024
@jrsteensen
Copy link
Owner

Have we tried installing the library as a submodule and calling it that way?

@Arribe
Copy link
Collaborator Author

Arribe commented Apr 4, 2024

It's a submodule header call from SimpleFOC...I didn't want to cause problems by adding a base Arduino header as a submodule...but I can certainly try it to see if that works.

@Arribe
Copy link
Collaborator Author

Arribe commented Apr 4, 2024

No luck. Adding the core ArduinoCore-avr as a sub module didn't work...and probably caused more problems since that is a base library that's included in every Arduino IDE. Adding SPI.h and SPI.cpp didn't work and caused more header files to be marked as missing.

@Arribe
Copy link
Collaborator Author

Arribe commented Apr 7, 2024

As far as I can tell ESP32 CI is broken. Trying a test sketch consisting of basically an empty file except including Wire.h or SPI.h CI fails. Though based on what I can see the following fragments should lead the CI to reaching those files:

OpenHornet Software's include/esp.mk has this line:
ESP_ROOT = $(ROOTDIR)/libraries/arduino-esp32

makeEspArduino
/makeEspArduino.mk has the following line:
ESP_LIBS = $(ESP_ROOT)/libraries

Then following the OpenHornet Software libraries folder links to the github entry below for ESP_ROOT/libraries:
https://github.com/espressif/arduino-esp32/tree/4b3aebe11fa5acc0f8b259105b4d1990b95c399b/libraries

The libraries folder has SPI, Wire directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Library This issue affects an embedded library other than DCS-BIOS. P2 High Priority: This is the defect or issue which should be resolved before the release is made. Thes S2 Major Severity: Any Major feature implemented that is not meeting its requirements/use case(s) and b Type: Bug Something is not working as expected.
Projects
Status: To do
Development

No branches or pull requests

2 participants