fix(browsers): ensuring acknowledgement is only necessary for browserstack

- short and quick selenium runs can send all xhr requests before
  the acknowledger can get lined up to listen for them. This was
  the case with jquery-mousewheel, which has been added in the tests.

Author: timmywil

.github/workflows/jquery-mousewheel.yml

@@ -0,0 +1,40 @@
+name: jQuery Mousewheel
+
+on:
+  pull_request:
+  push:
+    branches:
+      - main
+
+env:
+  NODE_VERSION: 22.x
+
+jobs:
+  build-and-test:
+    runs-on: ubuntu-latest
+    name: Test jQuery Mousewheel Integration
+    steps:
+      - name: Checkout
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          submodules: recursive
+
+      - name: Use Node.js ${{ env.NODE_VERSION }}
+        uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4.2.0
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+
+      - name: Cache
+        uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4.2.2
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-
+
+      - name: Install dependencies
+        run: npm install
+
+      - name: Run jQuery Mousewheel tests
+        working-directory: test/jquery-mousewheel
+        run: npm it

.gitmodules

@@ -7,3 +7,6 @@
 [submodule "test/jquery-ui"]
 	path = test/jquery-ui
 	url = [email protected]:jquery/jquery-ui.git
+[submodule "test/jquery-mousewheel"]
+	path = test/jquery-mousewheel
+	url = [email protected]:jquery/jquery-mousewheel.git

browsers.js

@@ -103,12 +103,12 @@ export async function createBrowserWorker( url, browser, options, restarts = 0 )
 	worker.browser = browser;
 	worker.restarts = restarts;
 	worker.options = options;
-	touchBrowser( browser );
 	workers[ fullBrowser ] = worker;
 
-	// Wait for the worker to show up in the list
-	// before returning it.
-	return ensureAcknowledged( worker );
+	// Wait for at least one response
+	// from the worker before continuing
+	await ensureAcknowledged( worker );
+	return worker;
 }
 
 export function touchBrowser( browser ) {

createTestServer.js

@@ -159,6 +159,7 @@ export async function createTestServer( {
 		".txt": "text/plain",
 		".log": "text/plain"
 	};
+
 	use( async( req, res, next ) => {
 
 		// Allow serving anything but node_modules,

run.js

@@ -80,10 +80,14 @@ export async function run( {
 		quiet: true, // Quiet server logs during test runs
 		testUrls,
 		report: async( message ) => {
+			const reportId = message.id;
+			const report = reports[ reportId ];
+
 			switch ( message.type ) {
+				case "ack":
+					touchBrowser( report.browser );
+					break;
 				case "testEnd": {
-					const reportId = message.id;
-					const report = reports[ reportId ];
 					touchBrowser( report.browser );
 					const errorMessage = reportTest( message.data, report );
 					pendingErrors[ reportId ] ??= Object.create( null );
@@ -107,17 +111,13 @@ export async function run( {
 					break;
 				}
 				case "error": {
-					const reportId = message.id;
-					const report = reports[ reportId ];
 					touchBrowser( report.browser );
 					const errorMessage = reportError( message.data );
 					pendingErrors[ reportId ] ??= Object.create( null );
 					pendingErrors[ reportId ][ message.data.message ] = errorMessage;
 					break;
 				}
 				case "runEnd": {
-					const reportId = message.id;
-					const report = reports[ reportId ];
 					touchBrowser( report.browser );
 					const { failed, total } = reportEnd( message.data, reports[ reportId ] );
 					report.total = total;
@@ -144,11 +144,6 @@ export async function run( {
 					// Run the next test
 					return getNextBrowserTest( reportId );
 				}
-				case "ack": {
-					const report = reports[ message.id ];
-					touchBrowser( report.browser );
-					break;
-				}
 				default:
 					console.warn( "Received unknown message type:", message.type );
 			}
@@ -340,16 +335,16 @@ export async function run( {
 		}
 	} finally {
 		console.log();
-		if ( errorMessages.length === 0 ) {
+		const numErrors = errorMessages.length;
+		if ( numErrors === 0 ) {
 			let stop = false;
 			for ( const report of Object.values( reports ) ) {
 				if ( !report.total ) {
 					stop = true;
 					console.error(
 						chalk.red(
-							`No tests were run with URL "${ report.url }" in ${
-								report.fullBrowser
-							} (${ report.id })`
+							`No tests were run with URL "${ report.url }" ` +
+								`in ${ report.fullBrowser } (${ report.id })`
 						)
 					);
 				}
@@ -363,8 +358,9 @@ export async function run( {
 				gracefulExit( 0 );
 			}
 		} else {
-			const len = errorMessages.length;
-			console.error( chalk.red( `${ len } test${ len > 1 ? "s" : "" } failed.` ) );
+			console.error(
+				chalk.red( `${ numErrors } test${ numErrors > 1 ? "s" : "" } failed.` )
+			);
 			console.log(
 				errorMessages.map( ( error, i ) => `\n${ i + 1 }. ${ error }` ).join( "\n" )
 			);

selenium/createDriver.js

@@ -88,8 +88,11 @@ export default async function createDriver( { browserName, headless, url, verbos
 	// Increase script timeout to 10min
 	await driver.manage().setTimeouts( { script: DRIVER_SCRIPT_TIMEOUT } );
 
-	// Set the first URL for the browser
-	await driver.get( url );
+	// Set the first URL for the browser,
+	// but don't wait for the page to load
+	// so the worker is set up in time
+	// for the ack request.
+	driver.get( url );
 
 	return driver;
 }