Skip to content
This repository was archived by the owner on Dec 11, 2021. It is now read-only.

Commit ff6e6c6

Browse files
committed
Performance: updating versions and configurations
1 parent 01f27af commit ff6e6c6

File tree

5 files changed

+28
-9
lines changed

5 files changed

+28
-9
lines changed

Gruntfile.js

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,14 @@ var config = {
100100
spawn: false
101101
}
102102
}
103+
},
104+
"stop-selenium-server": {
105+
dev: {}
103106
}
104107
};
105108

109+
// This loads files in the options folder as task options
110+
// and builds an object based on their file names
106111
function loadConfig(path) {
107112
var glob = require( "glob" ),
108113
object = {},
@@ -116,11 +121,18 @@ function loadConfig(path) {
116121
return object;
117122
}
118123

124+
// We no combine the loaded task options with the ones defined in config above
119125
grunt.util._.extend( config, loadConfig( "./tasks/options/" ) );
120126

121127
grunt.initConfig( config );
128+
grunt.loadTasks( "tasks" );
122129
grunt.loadNpmTasks( "perfjankie" );
123130
grunt.registerTask( "default", [ "jshint", "jscs" ] );
124131
grunt.registerTask( "build", [ "sass", "autoprefixer" ] );
125-
grunt.registerTask( "perf", [ "start-selenium-server", "connect:perf", "perfjankie" ] );
132+
grunt.registerTask( "perf", [
133+
"start-selenium-server",
134+
"connect:perf",
135+
"perfjankie",
136+
"stop-selenium-server"
137+
]);
126138
};

package.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,9 @@
4141
"test": "grunt"
4242
},
4343
"dependencies": {},
44-
"devDependencies": {
45-
"commitplease": "2.0.0",
44+
45+
"devDependencies": {
46+
"browser-perf": "1.2.3",
4647
"chromedriver": "2.13.0",
4748
"commitplease": "2.0.0",
4849
"ejs-template": "0.1.0",
@@ -60,7 +61,7 @@
6061
"grunt-svgmin": "^2.0.0",
6162
"grunt-svgstore": "^0.5.0",
6263
"load-grunt-tasks": "3.1.0",
63-
"perfjankie": "1.1.1"
64+
"perfjankie": "1.2.2"
6465
},
6566
"keywords": []
6667
}

tasks/options/connect.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ var template = require( "ejs-template" ),
44

55
module.exports = {
66
options: {
7-
port: 4300,
7+
port: 4200,
88
base: ".",
99
middleware: [
1010
template.middleware({ basedir: __dirname }),

tasks/options/perfjankie.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,14 @@ module.exports = {
55
"comparison": {
66
options: {
77
repeat: 2,
8-
selenium: "ondemand.saucelabs.com",
9-
browsers: "chrome",
8+
selenium: {
9+
hostname: "localhost",
10+
port: "4444"
11+
},
12+
browsers: [
13+
"chrome",
14+
"firefox"
15+
],
1016
couch: {
1117
server: "http://localhost:5984",
1218
database: "css-performance",

tasks/options/start-selenium-server.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
module.exports = {
22
dev: {
33
options: {
4-
downloadUrl: "https://selenium-release.storage.googleapis.com/2.40/" +
5-
"selenium-server-standalone-2.40.0.jar",
4+
downloadUrl: "https://selenium-release.storage.googleapis.com/2.45/" +
5+
"selenium-server-standalone-2.45.0.jar",
66
downloadLocation: "external/selenium",
77
serverOptions: {
88
"Dwebdriver.chrome.driver=node_modules/chromedriver/bin/chromedriver": ""

0 commit comments

Comments
 (0)