Always use PUBLIC/PRIVATE for target_link_libraries.

Author: ras0219-msft

Release/tests/common/TestRunner/CMakeLists.txt

@@ -7,12 +7,12 @@ if (WIN32)
 endif()
 
 add_executable(test_runner test_runner.cpp test_module_loader.cpp)
-target_link_libraries(test_runner unittestpp)
+target_link_libraries(test_runner PRIVATE unittestpp)
 
 if(BUILD_SHARED_LIBS)
-  target_link_libraries(test_runner ${CMAKE_DL_LIBS})
+  target_link_libraries(test_runner PRIVATE ${CMAKE_DL_LIBS})
 elseif(APPLE)
-  target_link_libraries(test_runner
+  target_link_libraries(test_runner PRIVATE
     -Wl,-force_load httpclient_test
     -Wl,-force_load json_test
     -Wl,-force_load uri_test
@@ -22,7 +22,7 @@ elseif(APPLE)
     -Wl,-force_load utils_test
     )
 elseif(UNIX)
-  target_link_libraries(test_runner
+  target_link_libraries(test_runner PRIVATE
     -Wl,--whole-archive
     httpclient_test
     json_test
@@ -47,16 +47,16 @@ else()
   if(NOT WINDOWS_STORE AND NOT WINDOWS_PHONE)
     target_sources(test_runner PRIVATE $<TARGET_OBJECTS:httplistener_test>)
   endif()
-  target_link_libraries(test_runner
+  target_link_libraries(test_runner PRIVATE
     common_utilities
     httptest_utilities
     cpprest
   )
   if(CPPREST_WEBSOCKETS_IMPL STREQUAL "wspp")
     cpprest_find_websocketpp()
-    target_link_libraries(test_runner cpprestsdk_websocketpp_internal)
+    target_link_libraries(test_runner PRIVATE cpprestsdk_websocketpp_internal)
   endif()
   if (WINDOWS_STORE)
-    target_link_libraries(test_runner ucrtd.lib vcruntimed.lib vccorlibd.lib msvcrtd.lib msvcprtd.lib concrtd.lib RuntimeObject.lib)
+    target_link_libraries(test_runner PRIVATE ucrtd.lib vcruntimed.lib vccorlibd.lib msvcrtd.lib msvcprtd.lib concrtd.lib RuntimeObject.lib)
   endif()
 endif()