return values for Model::create

[xadhoom]

Hi!

according to Model.php, in function create, we always have a model even if
the save has failed:

public static function create($attributes, $validate=true)
    {
        $class_name = get_called_class();
        $model = new $class_name($attributes);
        $model->save($validate);
        return $model;
    }

what is the best way to handle a failed save? I'm using is_new_record attribute to check if the model has been saved or not.
Is this the correct way ?
Or better not use create and use initialize+save directly ?

Or, is reasonable to change the create function to:

public static function create($attributes, $validate=true)
    {
        $class_name = get_called_class();
        $model = new $class_name($attributes);
        $res = $model->save($validate);
        if ( $res )
            return $model;
        else
            return $res;
    }

regards,
mat

[jpfuentes2]

A save should only fail if validations fail, or if you have a before_* callback setup that has returned false. In the case of validations, you could check $model->errors->is_empty() for whether or not there were validation errors. If a callback returned false, then your best bet would be is_new_record since it's possible it never made it to validations and $model->errors->is_empty() is really for validation purposes.

I don't think we'll change the return as some users may already have plenty of code expecting a model.

[kla]

Re-opening this. We could use something similar to create! like rails has.