Default finder options in model

[pmtarantino]

I did some changes in my local copy of php-active-record, because I needed to set up default values for the finder for each model.

For example:

class Person extends ActiveRecord\Model {
     *   static $default_options = array('order' => 'name ASC', 'limit' => 15);
     * }

I wanted to do a pull request, but I saw there were too many open requests, and they seem to be ignored.

Are you ignoring them on purpose or what? I'd like to collaborate with this (in fact, it's a simple change on the Model.php file), but I wouldn't like to be ignored :)

[koenpunt]

There is an ongoing discussion about scopes, which can do exactly what you want and even more: #306

[pmtarantino]

I know, but that discussion remains open and it not fully functional yet.

[anther]

If this particular implementation was merged in the problem then becomes that we have two features that work in the same way, ($default_options does a subset of what scopes do), while both change the API.

If you merge in the scopes branch you can do the same with:

 public function default_scope()
{
  return array('order' => 'name ASC', 'limit' => 15);
}
or
public static $default_scope =  array('order' => 'name ASC', 'limit' => 15); //Which is the same as what you have, except for the variable name =p

All of the previous unit tests pass in the current scope branch so the tested API for phpactiverecord can still be trusted while working with it.

[pmtarantino]

Oh, okay :) Thank you for your explanation. I will merge to the scope branch as soon as I can to test it in project.

[anther]

No problem. ;).

[al-the-x]

Hey, does that mean we can close this issue? If @anther's scopes branch helps, @pmtarantino, please close. Thx.

[pmtarantino]

It is not working 100% , but I am not the one who decides :)

[al-the-x]

Ah, okay. So you're still working out this issue, then? Ultimately it's you who decides whether your issue is really resolved. If we go closing issues for ppl without asking, either they re-open them, open new ones, or walk away. None of those options is good for anyone, really. Carry on!

[pmtarantino]

We are still working on it, but we are chatting over Gtalk.