Credential optimizations #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@joona is there anything I can do to help you to proceed here? |
Owner
|
Hi @martinzuern, thank you for pr and sorry for delay on gettin back to you. I tested your branch, but unfortunately it's not fully compatible with non-AWS environment usecases (i.e. local development, with credentials profile, etc). Since all outbound connections are handled on AWS SDK, it should handle the automatic refresh of credentials on demand when STS is used, at least this is my assumption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joona Thanks for your latest release! However I needed to add some more changes to make this work on ECS.
I removed your custom defaultProviders chain, as it didn't include ECSCredentials. Instead, I'm setting the
process.env.AWS_PROFILEvariable, so AWS SDK still behaves like in previous versions.AWS ECS Credentials require a refresh after some time, so I added a function that checks the credentials before every request and refreshes them if necessary.