Email cloak broken when link parameters are not parsed (Fix #4354)

pjmatos · Michael Babker · commit 6612437e4fc0 · 2014-09-29T10:55:19.000-04:00
diff --git a/plugins/content/emailcloak/emailcloak.php b/plugins/content/emailcloak/emailcloak.php
@@ -54,8 +54,7 @@ public function onContentPrepare($context, &$row, &$params, $page = 0)
 	 */
 	protected function _getPattern ($link, $text)
 	{
-		$pattern = '~(?:<a ([\w "\'=\@\.\-:;]*)href\s*=\s*"mailto:'
-			. $link . '"([\w "\'=\@\.\-:;]*))>' . $text . '</a>~i';
+		$pattern = '~(?:<a ([^>]*)href\s*=\s*"mailto:' . $link . '"([^>]*))>' . $text . '</a>~i';
 
 		return $pattern;
 	}

Original file line number	Diff line number	Diff line change
`@@ -54,8 +54,7 @@ public function onContentPrepare($context, &$row, &$params, $page = 0)`
`54`	`54`	`*/`
`55`	`55`	`protected function _getPattern ($link, $text)`
`56`	`56`	`{`
`57`		`- $pattern = '~(?:<a ([\w "\'=\@\.\-:;])href\s=\s*"mailto:'`
`58`		`- . $link . '"([\w "\'=\@\.\-:;]*))>' . $text . '</a>~i';`
	`57`	`+ $pattern = '~(?:<a ([^>])href\s=\s"mailto:' . $link . '"([^>]))>' . $text . '</a>~i';`
`59`	`58`
`60`	`59`	`return $pattern;`
`61`	`60`	`}`