Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate ms-stream for IE. #10

Closed
jonnyreeves opened this issue May 19, 2016 · 6 comments
Closed

Investigate ms-stream for IE. #10

jonnyreeves opened this issue May 19, 2016 · 6 comments
Milestone

Comments

@jonnyreeves
Copy link
Owner

https://msdn.microsoft.com/en-us/library/hh772328(v=vs.85).aspx

@ariutta
Copy link
Contributor

ariutta commented Jul 25, 2016

The requests (plural) library uses ms-stream. It even supports using ActiveX for old versions of IE. Could you start with that implementation?

@ariutta
Copy link
Contributor

ariutta commented Aug 18, 2016

I've got a rough ms-stream implementation here in the ms-stream branch of my fork.

@ariutta
Copy link
Contributor

ariutta commented Aug 19, 2016

I'll work on merging my ms-stream implementation into your latest feature code. (Actually, I'll wait until you can merge our latest work into master.) Any thoughts on the abstraction for streaming xhr? If I make a version to work with IE10+ and possible IE9, I don't know whether it's ideal to make another file named msXhr.js, because there will be quite a bit of code shared between xhr.js, mozXhr.js and msXhr.js. I could pull out the common code and only include it once. (We've decided to dedup the common code between XHR implementations.)

@ariutta
Copy link
Contributor

ariutta commented Aug 22, 2016

This comment is relevant to the question of how to make an abstraction that works with the IE ms-stream readAsArrayBuffer method.

@jonnyreeves jonnyreeves added this to the 0.6 milestone Aug 29, 2016
@jonnyreeves
Copy link
Owner Author

See https://github.com/jhiesey/stream-http/blob/master/lib/response.js#L157 - got a little disheartened when I first came across this library as it somewhat fulfils my original needs when writing this one! 😁 - however it would appear this one is turning into a slightly more modern interface which may prove useful for some.

@jonnyreeves
Copy link
Owner Author

Opened as jonnyreeves/fetch-readablestream#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants