Skip to content

APPEND support is incomplete #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonhoo opened this issue Nov 23, 2018 · 2 comments
Closed

APPEND support is incomplete #60

jonhoo opened this issue Nov 23, 2018 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed tombstone A reference to an old issue on mattnenterprise/rust-imap
Milestone

Comments

@jonhoo
Copy link
Owner

jonhoo commented Nov 23, 2018

At the moment APPEND only supports setting the body of the message. However, RFC3501 allows users to specify the flag set to be applied to a message, as well as the date the message was received. Quoting the specification:

6.3.11. APPEND Command

   Arguments:  mailbox name
               OPTIONAL flag parenthesized list
               OPTIONAL date/time string
               message literal

We could change the append method to:

use chrono::DateTime;
use chrono::offset::Utc;

fn append(&mut self, folder: &str,
          flags: Vec<String>,
          datetime: DateTime<Utc>,
          message: &[u8]) { /* ... */ } 

See the original issue here: mattnenterprise/rust-imap#60

@jonhoo jonhoo added tombstone A reference to an old issue on mattnenterprise/rust-imap enhancement New feature or request help wanted Extra attention is needed labels Nov 23, 2018
@jonhoo jonhoo added this to the imap 1.0 milestone Nov 23, 2018
@cyphar
Copy link

cyphar commented Nov 23, 2018

mattnenterprise/rust-imap#61 was my PoC for this.

@mblarsen
Copy link
Contributor

Would love to see the date feature implemented. Should I try to revise the old PR?

Any thoughts on the api? Keeping append as is and add append_with_flags_and_date to avoid breaking anything?

mblarsen added a commit to mblarsen/rust-imap that referenced this issue Dec 12, 2020
@jonhoo jonhoo closed this as completed in ee56c8e Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed tombstone A reference to an old issue on mattnenterprise/rust-imap
Projects
None yet
Development

No branches or pull requests

3 participants