Skip to content

Commit b00d7e7

Browse files
committed
style: use single quotes when double quotes not needed in shell scripts
1 parent 6443229 commit b00d7e7

File tree

5 files changed

+22
-22
lines changed

5 files changed

+22
-22
lines changed

.github/workflows/check-demos.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
# download and setup problem matcher for luacheck's visual_studio formatter
4949
wget -q "https://raw.githubusercontent.com/ammaraskar/msvc-problem-matcher/${MSCV_PROBLEM_MATCHER_VERSION}/msvc_matcher.json" \
5050
-O visual-studio-problem-matcher.json
51-
echo "::add-matcher::visual-studio-problem-matcher.json"
51+
echo '::add-matcher::visual-studio-problem-matcher.json'
5252
5353
# run luacheck
5454
luacheck ./demos/ --no-cache --formatter visual_studio

.github/workflows/check-workflows.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
# download and setup problem matcher for actionlint
4747
wget -q "https://raw.githubusercontent.com/rhysd/actionlint/${ACTIONLINT_VERSION}/.github/actionlint-matcher.json" \
4848
-O actionlint-problem-matcher.json
49-
echo "::add-matcher::actionlint-problem-matcher.json"
49+
echo '::add-matcher::actionlint-problem-matcher.json'
5050
5151
# run actionlint
5252
./actionlint -verbose -color

.github/workflows/check.yml

+11-11
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,14 @@ jobs:
4949
5050
# "notify" me of newer clang-format version
5151
if command -v clang-format-19 &> /dev/null; then
52-
echo "clang-format-19 is available"
52+
echo 'clang-format-19 is available'
5353
exit 2
5454
fi
5555
5656
shopt -s nullglob
5757
files=(src/*.c src/**/*.c include/*.h include/**/*.h)
5858
if [[ "${#files[@]}" -eq 0 ]]; then
59-
echo "No files found"
59+
echo 'No files found'
6060
exit 1
6161
fi
6262
clang-format-18 --verbose --dry-run --Werror "${files[@]}"
@@ -67,7 +67,7 @@ jobs:
6767
6868
# "notify" me of newer clang-tidy version
6969
if command -v clang-tidy-19 &> /dev/null; then
70-
echo "clang-tidy-19 is available"
70+
echo 'clang-tidy-19 is available'
7171
exit 2
7272
fi
7373
@@ -83,14 +83,14 @@ jobs:
8383
shopt -s nullglob
8484
files=(src/*.c src/**/*.c include/*.h include/**/*.h)
8585
if [[ "${#files[@]}" -eq 0 ]]; then
86-
echo "No files found"
86+
echo 'No files found'
8787
exit 1
8888
fi
89-
clang-tidy-18 --warnings-as-errors="*" --extra-arg="-I/usr/include/lua5.1" "${files[@]}"
90-
clang-tidy-18 --warnings-as-errors="*" --extra-arg="-I/usr/include/lua5.2" "${files[@]}"
91-
clang-tidy-18 --warnings-as-errors="*" --extra-arg="-I/usr/include/lua5.3" "${files[@]}"
92-
clang-tidy-18 --warnings-as-errors="*" --extra-arg="-I/usr/include/lua5.4" "${files[@]}"
93-
clang-tidy-18 --warnings-as-errors="*" --extra-arg="-I/usr/include/luajit-2.1" "${files[@]}"
89+
clang-tidy-18 --warnings-as-errors='*' --extra-arg='-I/usr/include/lua5.1' "${files[@]}"
90+
clang-tidy-18 --warnings-as-errors='*' --extra-arg='-I/usr/include/lua5.2' "${files[@]}"
91+
clang-tidy-18 --warnings-as-errors='*' --extra-arg='-I/usr/include/lua5.3' "${files[@]}"
92+
clang-tidy-18 --warnings-as-errors='*' --extra-arg='-I/usr/include/lua5.4' "${files[@]}"
93+
clang-tidy-18 --warnings-as-errors='*' --extra-arg='-I/usr/include/luajit-2.1' "${files[@]}"
9494
9595
- name: Set up Lua
9696
uses: luarocks/gh-actions-lua@master
@@ -111,10 +111,10 @@ jobs:
111111
# download and setup problem matcher for luacheck's visual_studio formatter
112112
wget -q "https://raw.githubusercontent.com/ammaraskar/msvc-problem-matcher/${MSCV_PROBLEM_MATCHER_VERSION}/msvc_matcher.json" \
113113
-O visual-studio-problem-matcher.json
114-
echo "::add-matcher::visual-studio-problem-matcher.json"
114+
echo '::add-matcher::visual-studio-problem-matcher.json'
115115
116116
# run luacheck
117-
luacheck . --no-cache --formatter visual_studio --include-files "spec/**/*.lua" "**/*.rockspec" --exclude-files .lua .luarocks
117+
luacheck . --no-cache --formatter visual_studio --include-files 'spec/**/*.lua' '**/*.rockspec' --exclude-files .lua .luarocks
118118
119119
120120
test:

.github/workflows/release.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,16 @@ jobs:
3838
3939
version="${GITHUB_REF_NAME}"
4040
rockspec="fenster-${version#v}-1.rockspec"
41-
git mv fenster-dev-1.rockspec "$rockspec"
42-
sed -i -E "s/\bversion\s*=\s*('|\"|\[\[)\s*[a-zA-Z0-9.-]+\s*('|\"|\]\])/version = '${version#v}-1'/" "$rockspec"
43-
sed -i -E "s/\bbranch\s*=\s*('|\"|\[\[)\s*[a-zA-Z0-9.-_\/]+\s*('|\"|\]\])/tag = '$version'/" "$rockspec"
41+
git mv fenster-dev-1.rockspec "${rockspec}"
42+
sed -i -E "s/\bversion\s*=\s*('|\"|\[\[)\s*[a-zA-Z0-9.-]+\s*('|\"|\]\])/version = '${version#v}-1'/" "${rockspec}"
43+
sed -i -E "s/\bbranch\s*=\s*('|\"|\[\[)\s*[a-zA-Z0-9.-_\/]+\s*('|\"|\]\])/tag = '$version'/" "${rockspec}"
4444
git diff
45-
if [[ -z "$(git status --porcelain "$rockspec")" ]]; then
46-
echo "Rockspec not modified"
45+
if [[ -z "$(git status --porcelain "${rockspec}")" ]]; then
46+
echo 'Rockspec not modified'
4747
exit 1
4848
fi
4949
luarocks install dkjson
50-
luarocks upload --temp-key "${{ secrets.LUAROCKS_API_KEY }}" "$rockspec"
50+
luarocks upload --temp-key "${{ secrets.LUAROCKS_API_KEY }}" "${rockspec}"
5151
5252
- name: Draft release on GitHub
5353
uses: softprops/action-gh-release@e7a8f85e1c67a31e6ed99a94b41bd0b71bbee6b8 # v2.0.9

docker-compose.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,17 @@ x-build-preset: &build_preset
99
SHELL ["/bin/bash", "-euxo", "pipefail", "-c"]
1010
RUN IFS=$$' \n\t'; \
1111
\
12-
echo "**** install system packages ****"; \
12+
echo '**** install system packages ****'; \
1313
apt-get update; \
1414
apt-get install --no-install-recommends --yes \
1515
build-essential \
1616
libx11-dev \
1717
; \
18-
echo "**** install luarocks packages ****"; \
18+
echo '**** install luarocks packages ****'; \
1919
luarocks install --no-doc \
2020
busted \
2121
; \
22-
echo "**** cleanup ****"; \
22+
echo '**** cleanup ****'; \
2323
rm -rf \
2424
/tmp/* \
2525
/var/lib/apt/lists/* \

0 commit comments

Comments
 (0)