ci: run clang-tidy for each lua version individually

Author: jonasgeiler

.github/workflows/check.yml

@@ -71,16 +71,26 @@ jobs:
             exit 2
           fi
           
-          # install X11 headers
-          sudo apt-get install --yes --no-install-recommends libx11-dev
+          # get required header files
+          sudo apt-get install --yes --no-install-recommends \
+            libx11-dev \
+            liblua5.1-dev \
+            liblua5.2-dev \
+            liblua5.3-dev \
+            liblua5.4-dev \
+            libluajit-5.1-dev
 
           shopt -s nullglob
           files=(src/*.c src/**/*.c include/*.h include/**/*.h)
           if [[ "${#files[@]}" -eq 0 ]]; then
             echo "No files found"
             exit 1
           fi
-          clang-tidy-18 --extra-arg="-I.lua/include" --warnings-as-errors="*" "${files[@]}"
+          clang-tidy-18 --warnings-as-errors="*" --extra-arg="-I/usr/include/lua5.1" "${files[@]}"
+          clang-tidy-18 --warnings-as-errors="*" --extra-arg="-I/usr/include/lua5.2" "${files[@]}"
+          clang-tidy-18 --warnings-as-errors="*" --extra-arg="-I/usr/include/lua5.3" "${files[@]}"
+          clang-tidy-18 --warnings-as-errors="*" --extra-arg="-I/usr/include/lua5.4" "${files[@]}"
+          clang-tidy-18 --warnings-as-errors="*" --extra-arg="-I/usr/include/luajit-2.1" "${files[@]}"
 
       - name: Set up Lua
         uses: luarocks/gh-actions-lua@master
@@ -136,6 +146,10 @@ jobs:
         # Will be ignored on non-Windows platforms anyway, but it's better to just skip it
         if: matrix.os == 'windows-latest'
 
+      - name: Set up X11
+        if: matrix.os == 'ubuntu-latest'
+        run: sudo apt-get install --yes --no-install-recommends libx11-dev
+
       - name: Set up Lua
         uses: luarocks/gh-actions-lua@master
         with:

src/main.c

@@ -24,7 +24,7 @@
    luaL_checkinteger(L, arg))
 
 #define luaL_optinteger(L, arg, def) \
-  (lua_isnoneornil(L, arg) ? def : luaL_checkinteger(L, arg))
+  (lua_isnoneornil(L, arg) ? (def) : luaL_checkinteger(L, arg))
 
 #endif
 
@@ -629,6 +629,7 @@ FENSTER_EXPORT int luaopen_fenster(lua_State *L) {
   luaL_setfuncs(L, window_methods, 0);
 
   // create and return the fenster Lua module
-  luaL_newlib(L, lfenster_functions);
+  luaL_newlib(  // NOLINT(readability-math-missing-parentheses)
+      L, lfenster_functions);
   return 1;
 }