-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Letter/Circle waymarks render incorrectly in Firefox #35
Comments
This is super weird. I'm pretty sure it's either a bug in Firefox or Konva, but I found that it only happens when the shape is exactly circular, so I can work around it by making sure it always slightly elliptical. |
Created an issue with Konva here: konvajs/konva#1864 |
I've added a workaround. Looks like it's working correctly for me now, but please let me know if it's still broken for you. |
It is indeed still broken for me. Is there anything specific I could provide that might help track it down? |
Can you try entering about:profiles in the address bar, creating a new profile, and checking if the issue still occurs with default settings? Also, does the issue still occur if you resize the waymark object horizontally or vertically so that it's no longer circular? I won't be able to test on Windows 10, but any other info about your system could also be useful. What screen resolution and GPU do you have? |
It does seem to work correctly with a new profile, though I'm not sure what settings could have been changed; this happened immediately on a fresh install of Firefox. On the original profile, resizing vertically or horizontally fixes the render. Interestingly, resizing diagonally mostly does as well, but some specific sizes still seem to show the issue. Display resolutions of 2560x1440 and 3440x1440. GPU is an RTX 2080 SUPER. |
Make dashed circle outlines even more elliptical on Firefox to see if this fully works around #35. Also adjusted the hack to only apply on Firefox (and derivatives) by checking for "Gecko" in the user agent.
Try it now? I'm not really sure what else to try, so I just made it even more elliptical. The fact that a new profile doesn't show the issue, but a fresh install does, is really confusing. If the issue itself doesn't happen consistently, that could certainly explain why it might be fixed for me but not for you. I'm testing on a 4070 Ti Super, but I wouldn't expect that to be the difference since they're both Nvidia GPUs. If this latest change still doesn't fix it, could you tell me what your display scaling is set to and paste a screenshot of https://jsbin.com/zidilowiyu/1/edit?js,output so I can compare to what I see? I do have a 4K monitor, so I should be able to reproduce the same setup as your 2560x1440 monitor if I know what display scaling to use. |
I've created a Firefox bug report. You can track it here: https://bugzilla.mozilla.org/show_bug.cgi?id=1937929 |
Describe the bug
Circular/Letter waymarks render as extremely thick, solid 7/8ths of a circle, instead of with a dotted line.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Would expect a dotted line circle, as with the square waymarks.
Please complete the following information:
The text was updated successfully, but these errors were encountered: