Skip to content

Commit 8ebdbf4

Browse files
committed
support node 24
1 parent 3004bfb commit 8ebdbf4

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

.devcontainer/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM mcr.microsoft.com/devcontainers/javascript-node:22
1+
FROM mcr.microsoft.com/devcontainers/javascript-node:24
22

33
# need to run update and install at the same time to prevent stale update layer
44
RUN apt-get update && apt-get install -y gdb clang-format openjdk-21-jdk maven

.github/workflows/master.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
runs-on: ubuntu-latest
1010
strategy:
1111
matrix:
12-
nodeVersion: [ 20, 22 ]
12+
nodeVersion: [ 20, 22, 24 ]
1313
jdkVersion: [ openjdk9, openjdk10, openjdk11, openjdk21 ]
1414
steps:
1515
- name: Checkout source code

.github/workflows/pull-requests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
runs-on: ubuntu-latest
1111
strategy:
1212
matrix:
13-
nodeVersion: [ 20, 22 ]
13+
nodeVersion: [ 20, 22, 24 ]
1414
jdkVersion: [ openjdk9, openjdk10, openjdk11, openjdk21 ]
1515
steps:
1616
- name: Checkout source code

src-cpp/javaObject.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ NAN_INDEX_GETTER(JavaObject::indexGetter) {
325325
assertNoException(env);
326326
if ((jint)index >= arrayLength) {
327327
info.GetReturnValue().SetUndefined();
328-
return;
328+
return v8::Intercepted::kYes;
329329
}
330330

331331
jmethodID array_get = env->GetStaticMethodID(arrayClass, "get", "(Ljava/lang/Object;I)Ljava/lang/Object;");

0 commit comments

Comments
 (0)