Added extra mutation

Author: Biatbe13

simulator/src/main/java/byzzbench/simulator/protocols/hbft/mutator/ViewChangeMessageFactory.java

@@ -8,9 +8,11 @@
 
 import org.springframework.stereotype.Component;
 
+import byzzbench.simulator.Replica;
 import byzzbench.simulator.faults.FaultContext;
 import byzzbench.simulator.faults.factories.MessageMutatorFactory;
 import byzzbench.simulator.faults.faults.MessageMutationFault;
+import byzzbench.simulator.protocols.hbft.HbftJavaReplica;
 import byzzbench.simulator.protocols.hbft.message.RequestMessage;
 import byzzbench.simulator.protocols.hbft.message.ViewChangeMessage;
 import byzzbench.simulator.transport.Event;
@@ -455,6 +457,40 @@ public void accept(FaultContext serializable) {
 
                 //     }
                 // }
+                ,
+                new MessageMutationFault("hbft-view-change-first-req-in-R", "Change first request in R", List.of(ViewChangeMessage.class)) {
+                    @Override
+                    public void accept(FaultContext serializable) {
+                        Optional<Event> event = serializable.getEvent();
+                        if (event.isEmpty()) {
+                            throw invalidMessageTypeException;
+                        }
+                        if (!(event.get() instanceof MessageEvent messageEvent)) {
+                            throw invalidMessageTypeException;
+                        }
+                        if (!(messageEvent.getPayload() instanceof ViewChangeMessage message)) {
+                            throw invalidMessageTypeException;
+                        }
+                        String senderId = messageEvent.getSenderId();
+                        Replica sender = serializable.getScenario().getReplicas().get(senderId);
+                        SortedMap<Long, RequestMessage> requests = message.getRequestsR();
+                        Entry<Long, RequestMessage> firstReq = requests.firstEntry();
+                        if (sender instanceof HbftJavaReplica replica) {
+                            SortedMap<Long, RequestMessage> specRequests = replica.getSpeculativeRequests();
+                            for (Long key : specRequests.keySet()) {
+                                if (!specRequests.get(key).equals(firstReq.getValue())) {
+                                    requests.remove(firstReq.getKey());
+                                    requests.put(firstReq.getKey(), specRequests.get(key));
+                                    ViewChangeMessage mutatedMessage = message.withRequestsR(requests);
+                                    mutatedMessage.sign(message.getSignedBy());
+                                    messageEvent.setPayload(mutatedMessage);
+                                    break;
+                                }
+                            }
+                        }
+                        
+                    }
+                }
                 // //TODO: be able to change the first or last request
 
 

simulator/src/main/java/byzzbench/simulator/transport/Transport.java

@@ -314,7 +314,7 @@ public synchronized void deliverEvent(long eventId) throws Exception {
 
         // if it is a MessageEvent and there is no connectivity between the nodes, drop it
         if (e instanceof MessageEvent m && !router.haveConnectivity(m.getSenderId(), m.getRecipientId())) {
-            log.info("Dropped: " + m.getSenderId() + "->" + m.getRecipientId() + ": " + m.getPayload());
+            //log.info("Dropped: " + m.getSenderId() + "->" + m.getRecipientId() + ": " + m.getPayload());
             m.setStatus(Event.Status.DROPPED);
             return;
         }
@@ -341,7 +341,7 @@ public synchronized void deliverEvent(long eventId) throws Exception {
             }
         }
 
-        log.info("Delivered " + e);
+        //log.info("Delivered " + e);
     }
 
     /**
@@ -361,7 +361,7 @@ public synchronized void dropEvent(long eventId) {
         }
         e.setStatus(Event.Status.DROPPED);
         this.observers.forEach(o -> o.onEventDropped(e));
-        log.info("Dropped: " + e);
+        //log.info("Dropped: " + e);
     }
 
     /**
@@ -432,7 +432,7 @@ public synchronized void applyMutation(long eventId, Fault fault) {
         this.scenario.getSchedule().appendEvent(mutateMessageEvent);
         this.observers.forEach(o -> o.onMessageMutation(mutateMessageEvent.getPayload()));
 
-        log.info("Mutated: " + m);
+        //log.info("Mutated: " + m);
     }
 
     public synchronized void applyFault(String faultId) {
@@ -485,7 +485,7 @@ public synchronized long setTimeout(Node node, Runnable runnable,
                 .build();
         this.appendEvent(timeoutEvent);
         this.observers.forEach(o -> o.onTimeout(timeoutEvent));
-        log.info("Timeout set for " + node.getId() + " in " + timeout + "ms: " + timeoutEvent);
+        //log.info("Timeout set for " + node.getId() + " in " + timeout + "ms: " + timeoutEvent);
         return timeoutEvent.getEventId();
     }
 
@@ -503,8 +503,8 @@ public synchronized long setTimeout(Replica replica, Runnable runnable,
         this.observers.forEach(o -> o.onTimeout(timeoutEvent));
 
 
-        log.info(description + " timeout set for " + replica.getId() + " in " +
-                timeout + "ms: " + timeoutEvent);
+        //log.info(description + " timeout set for " + replica.getId() + " in " +
+                //timeout + "ms: " + timeoutEvent);
         return timeoutEvent.getEventId();
     }
 
@@ -523,8 +523,8 @@ public synchronized long setClientTimeout(String clientId, Runnable runnable,
         this.observers.forEach(o -> o.onTimeout(timeoutEvent));
 
 
-        log.info("Timeout set for " + clientId + " in " +
-                timeout + "ms: " + timeoutEvent);
+        //log.info("Timeout set for " + clientId + " in " +
+                //timeout + "ms: " + timeoutEvent);
         return timeoutEvent.getEventId();
     }
 

simulator/src/main/resources/application.yml

@@ -22,8 +22,8 @@ byzzbench:
   outputSchedules: buggy # which schedules to write to file? one of 'all', 'buggy' or 'none'
 
   scheduler:
-    id: "byzzfuzz" # The ID of the scheduler to use
-    executionMode: async # async (default, any message delivered) or sync (communication-closure hypothesis, FIFO)
+    id: "random" # The ID of the scheduler to use
+    executionMode: sync # async (default, any message delivered) or sync (communication-closure hypothesis, FIFO)
     maxDropMessages: 0 # Maximum number of messages to drop per scenario
     maxMutateMessages: 0 # Maximum number of messages to mutate per scenario
     deliverTimeoutWeight: 1 # The weight for scheduler to trigger a timeout
@@ -34,7 +34,7 @@ byzzbench:
     params: # additional parameters for the scheduler
       # ByzzFuzz
       numRoundsWithProcessFaults: 1
-      numRoundsWithNetworkFaults: 1
+      numRoundsWithNetworkFaults: 0
       numRoundsWithFaults: 2
       # Twins
       numReplicas: 1