introduce bug

Author: AFNowakowski

simulator/src/main/java/byzzbench/simulator/protocols/tendermint/TendermintReplica.java

@@ -180,15 +180,13 @@ private boolean fulfillProposalRule3(ProposalMessage proposalMessage) {
         boolean proposalExists = messageLog.getProposals().getOrDefault(proposalMessage.getBlock(), new ArrayList<>()).stream()
                 .filter(proposal -> proposal.getHeight() == height)
                 .filter(proposal -> proposal.getRound() == proposalMessage.getRound())
-                .filter(proposal -> proposal.getRound() == this.round)
                 .filter(proposal -> proposal.getReplicaId().equals(proposer(height, proposalMessage.getRound())))
                 .count() >= 1;
 
         // AND 2f + 1 ⟨PRECOMMIT, hp, r, id(v)⟩
         boolean enoughPrecommits = messageLog.getPrecommits().getOrDefault(proposalMessage.getBlock(), new ArrayList<>()).stream()
                 .filter(precommit -> precommit.getHeight() == height)
                 .filter(precommit -> precommit.getRound() == proposalMessage.getRound())
-                .filter(precommit -> precommit.getRound() == this.round)
                 .count() >= 2 * tolerance + 1;
 
         // while decisionp[hp] = nil
@@ -538,13 +536,11 @@ protected void handlePrecommit(PrecommitMessage precommitMessage) {
     private boolean fulfillProposalPrecommitRule(PrecommitMessage precommitMessage) {
         boolean enoughPrecommits = messageLog.getPrecommits().getOrDefault(precommitMessage.getBlock(), new ArrayList<>()).stream()
                 .filter(precommit -> precommit.getHeight() == this.height)
-                .filter(precommit -> precommit.getRound() == this.round)
                 .count() >= 2 * tolerance + 1;
 
         boolean proposalExists = messageLog.getProposals().getOrDefault(precommitMessage.getBlock(), new ArrayList<>()).stream()
                 .filter(proposal -> proposal.getHeight() == this.getHeight())
                 .filter(proposal -> proposal.getRound() == precommitMessage.getRound())
-                .filter(proposal -> proposal.getRound() == this.round)
                 .filter(proposal -> proposal.getReplicaId().equals(proposer(precommitMessage.getHeight(), precommitMessage.getRound())))
                 .count() >= 1;
 
@@ -650,15 +646,8 @@ protected boolean validateMessage(MessagePayload message) {
 
         // Check that the message height matches the current height
         if (message instanceof GenericMessage) {
-            if (((GenericMessage) message).getHeight() < height || ((GenericMessage) message).getRound() < round) {
-                log.warning("Message height or round mismatch: " + ((GenericMessage) message).getHeight());
-                return true;
-            }
-            if (((GenericMessage) message).getAuthor().equals(this.getId())) {
-                if (message instanceof ProposalMessage ) {
-                    log.warning("Can accept proposals from itself: " + ((GenericMessage) message).getRound());
-                    return false;
-                }
+            if (((GenericMessage) message).getHeight() < height) {
+                log.warning("Message height mismatch: " + ((GenericMessage) message).getHeight());
                 return true;
             }
         }

simulator/src/main/resources/application.yml

@@ -33,8 +33,8 @@ byzzbench:
     mutateMessageWeight: 50 # The weight for scheduler to mutate a message
     params: # additional parameters for the scheduler
       # ByzzFuzz
-      numRoundsWithProcessFaults: 3
-      numRoundsWithNetworkFaults: 4
+      numRoundsWithProcessFaults: 2
+      numRoundsWithNetworkFaults: 2
       numRoundsWithFaults: 3
       # Twins
       numReplicas: 2