Add new mutator for PROPOSE message and other logs

Author: adduta

simulator/src/main/java/byzzbench/simulator/protocols/fab2/FastByzantineReplica.java

@@ -31,7 +31,6 @@ public class FastByzantineReplica extends LeaderBasedProtocolReplica {
 
     // The number of replicas in the system with each role.
     private final int p, a, l, f;
-    // The message round number.
     private long viewNumber;
     private long proposalNumber;
     // The value that the leader replica is proposing - changes each round, depending on the client request.
@@ -386,7 +385,11 @@ private void handleAcceptMessage(String sender, AcceptMessage acceptMessage) {
             moveToNextProposal();
         }
 
-        log.info("Learner " + getId() + " received ACCEPT from " + sender + " and proposal number " + proposalNumber);
+        log.info("Learner " + getId() +
+                " received ACCEPT from " + sender +
+                " and proposal number " + sequenceNumber
+        + " with value " + new String(acceptMessage.getValueAndProposalNumber().getValue()));
+
         int acceptedThreshold = (int) Math.ceil((a + (3 * f) + 1) / 2.0);
         boolean isAccepted = messageLog.onAccept(sender, acceptMessage, acceptedThreshold);
         operation = acceptMessage.getValueAndProposalNumber().getValue();
@@ -443,9 +446,10 @@ private void handleLearnMessageProposer(String sender, LearnMessage learnMessage
                 isSatisfied = true;
             }
 
+            // Leader is ready to move to the next request.
             // Leader is ready to move to the next request.
             if (isLeader() && !requests.isEmpty()
-            && messageLog.getProposersWithLearnedValue().size() >= p) {
+            && messageLog.getProposersWithLearnedValue().size() >= l) {
                 Serializable request = requests.poll();
                 this.proposalNumber++;
                 log.info("Increasing proposal number: " + this.proposalNumber);
@@ -499,9 +503,9 @@ private void handleLearnMessageLearner(String sender, LearnMessage learnMessage)
 
                 log.info("Learner " + getId() + " sending reply to client...");
                 this.sendReplyToClient(clientId, learnMessage.getValueAndProposalNumber().getValue());
-
             }
 
+            multicastMessage(new LearnMessage(learnMessage.getValueAndProposalNumber()), this.proposerNodeIds);
             if (this.learnerTimeoutId != -1) this.clearTimeout(this.learnerTimeoutId);
         } else {
             log.info("Learner " + getId() + " has not learned the value yet");

simulator/src/main/java/byzzbench/simulator/protocols/fab2/MessageLog.java

@@ -179,6 +179,11 @@ public boolean onAccept(String senderId, AcceptMessage acceptMessage, int thresh
             }
         });
 
+        // Log the values in the acceptorsWithAcceptedProposals
+        acceptorsWithAcceptedProposal.forEach((k, v) -> {
+            log.info("Acceptor " + k + " accepted value " + Arrays.toString(v.getValue()) + " with proposal number " + v.getProposalNumber());
+        });
+
         log.info("The number of accepted values for the same proposal value is " + currentAccepted.get());
         if (currentAccepted.get() >= threshold) {
             log.info("The learner has learned the value");
@@ -188,7 +193,7 @@ public boolean onAccept(String senderId, AcceptMessage acceptMessage, int thresh
         }
 
         // Remove message from the acceptMessages map
-//        if (acceptMessages.containsKey(proposalNumber)) acceptMessages.get(proposalNumber).remove(acceptMessage);
+        if (acceptMessages.containsKey(proposalNumber)) acceptMessages.get(proposalNumber).remove(acceptMessage);
 
         return false;
     }
@@ -224,6 +229,7 @@ public boolean learnerHasLearnedValue(Pair learnValue, int quorum) {
             }
         });
 
+        log.info("The number of learned values for the same proposal value is " + currentLearnedWithSamePair.get());
         if (currentLearnedWithSamePair.get() >= quorum && learnedValue == null) {
             this.learnedValue = learnValue;
             return true;

simulator/src/main/java/byzzbench/simulator/protocols/fab2/mutator/ProposeMessageMutatorFactory2.java

@@ -118,6 +118,41 @@ public void accept(FaultContext serializable) {
                                         ))
                         );
 
+                        messageEvent.setPayload(mutatedMessage);
+                    }
+                },
+
+                new MessageMutationFault(
+                        "fab-propose-value",
+                        "Any Propose Number",
+                        List.of(ProposeMessage.class)
+                ) {
+                    @Override
+                    public void accept(FaultContext serializable) {
+                        Optional<Event> event = serializable.getEvent();
+                        Random random = new Random();
+                        int mutation = random.nextInt(2, 100);
+
+                        if (event.isEmpty()) {
+                            throw new IllegalArgumentException("Invalid message type");
+                        }
+
+                        if (!(event.get() instanceof MessageEvent messageEvent)) {
+                            throw new IllegalArgumentException("Invalid message type");
+                        }
+
+                        if (!(messageEvent.getPayload() instanceof ProposeMessage message)) {
+                            throw new IllegalArgumentException("Invalid message type");
+                        }
+
+                        ProposeMessage mutatedMessage = message.withValueAndProposalNumber(
+                                new Pair("value".getBytes(),
+                                        new ProposalNumber(
+                                                message.getValueAndProposalNumber().getProposalNumber().getViewNumber(),
+                                                message.getValueAndProposalNumber().getProposalNumber().getSequenceNumber()
+                                        ))
+                        );
+
                         messageEvent.setPayload(mutatedMessage);
                     }
                 }