Skip to content

Commit cfdccd8

Browse files
committed
Avoid using both Yarn and NPM
Having both `yarn.lock` and `package-lock.json` (i.e. using both Yarn and NPM) could [easily](yarnpkg/yarn#5654) [be](yarnpkg/yarn#3614) [problematic](https://stackoverflow.com/questions/44552348/should-i-commit-yarn-lock-and-package-lock-json-files). In short, it creates a risk of out-of-sync where one author installs with NPM and forgot to update yarn.lock so another author, when using yarn, won't have that dependency. In this PR I propose to drop the use of yarn in favor of NPM since a search in the codebase yields more NPM usages (especially in the doc and in package.json) than Yarn (only in Docker file to install). If others have strong reasons for using Yarn over NPM then feel free to yield them. I don't have strong personal reason for one over another :D
1 parent 5a5e49b commit cfdccd8

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,12 @@ RUN curl -sL https://deb.nodesource.com/setup_12.x | bash -
1010
RUN apt-get install -y --no-install-recommends nodejs && \
1111
apt-get clean && \
1212
rm -rf /var/lib/apt/lists/*
13-
RUN npm install -g yarn
1413

1514
ADD requirements.txt .
1615
RUN pip install -r requirements.txt
1716

1817
ADD package.json package-lock.json ./
19-
RUN yarn install
18+
RUN npm instal
2019

2120
# ENV should be configure from outside
2221
# @see docker-compose.yaml

0 commit comments

Comments
 (0)