Skip to content

Latest commit

 

History

History
67 lines (34 loc) · 2.31 KB

File metadata and controls

67 lines (34 loc) · 2.31 KB

Changes since last review on MR

TL;DR

This page describes how to add a comment to find the changes since the last review.

comment
Note
UPDATE: we came up with the same approach working as a bot that reacts on the Comment Webhook event sent by GitLab: u-needs-work

Context

GitLab does not support sending a review with the request to perform changes.

In Bitbucket:

Needs work button in Bitbucket

In GitHub:

Request changes in GitHub

Open issues in GitLab:

The current workaround is to submit a review without approving:

submit review

Problem

The problem is that when the reviewer comes back on the MR, he has to remember what was changed since his last review.

In Bitbucket this is nicely solved, by selecting the "changes since you last reviewed" option in the diff view:

changes since you last reviewed

In GitHub there is a "view changes" button to acess the same diff:

github view changes

Possible solution

GitLab (version 15.7.7-ee at time of writting) supports comparing versions in the diff view.

The missing point is keeping track of the reviewed commit. The proposed script AddReviewAtComment.java helps keeping a record of the reviewed commit, by adding a comment. This comment contains a link to <mr-web-url>/diffs?start_sha=<reviewed-commit> in order for the user to have a link "changes since then".

comment

If you want a bot to post those comment, you can have a look at the u-needs-work project. It reacts at some keywords that can be added to the review comment.