Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json file with more size is not loading #386

Open
vinsjr opened this issue Mar 29, 2022 · 10 comments
Open

json file with more size is not loading #386

vinsjr opened this issue Mar 29, 2022 · 10 comments

Comments

@vinsjr
Copy link

vinsjr commented Mar 29, 2022

HI ,

If i use to load small json file then it is working but at same time if I ran 11MB file then it is giving me error as below,
Something went wrong.
Check the JS console for more details.

Could you please help me in this issues

@bjorn3
Copy link

bjorn3 commented Mar 29, 2022

What error is shown in the js console?

@vinsjr
Copy link
Author

vinsjr commented Mar 29, 2022

Where to check js console as i was using chrome browser not sure where to check this js console,

@bjorn3
Copy link

bjorn3 commented Mar 29, 2022

Press F12 and then at the top of the pane that opens click on "console".

@vinsjr
Copy link
Author

vinsjr commented Mar 29, 2022

This is the errors,
Failed to load format RangeError: Maximum call stack size exceeded
at Array.sort ()
at e (profile.ts:191:21)
at Array.forEach ()
at e (profile.ts:192:21)
at Array.forEach ()
at e (profile.ts:192:21)
at Array.forEach ()
at e (profile.ts:192:21)
at Array.forEach ()
at e (profile.ts:192:21)

@vinsjr
Copy link
Author

vinsjr commented Mar 29, 2022

But same was working for short data.. if ran for more number of scans then it is throwing an error

@bjorn3
Copy link

bjorn3 commented Mar 29, 2022

Maximum call stack size exceeded

That is a browser limitation. It may be possible to rewrite the profile loader to avoid this limitation. I'm not familiar with the actual code of speedscope though.

@vinsjr
Copy link
Author

vinsjr commented Mar 29, 2022

OK what is maximum size it supported now? and if want to change where I can change ?

@bjorn3
Copy link

bjorn3 commented Mar 29, 2022

OK what is maximum size it supported now?

Depends on the browser.

and if want to change where I can change ?

According to https://stackoverflow.com/questions/35380984/increasing-stack-size-in-browsers you can do something like

ulimit -c unlimited
chrome-browser --js-flags="--stack-size 2048"

(ignore the ulimit -c unlimited if you are on windows)

You will likely need to quit chrome entirely before doing this. In addition it is not a persistent option. Even this may still not work depending on how deep speedscope recurses when loading your profile.

@jlfwong
Copy link
Owner

jlfwong commented Apr 4, 2022

Hi @vinsjr!

It's difficult to help without having the file that isn't loading. If you can provide the file that isn't loading, it may be possible to debug your issue & resolve. Without the file, I'm afraid I can't do much to help.

@tom93
Copy link
Contributor

tom93 commented Feb 5, 2024

I'm pretty sure this specific stack overflow would be fixed by #438 (the method names and line number match this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants