Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught exception when WebSocketSend called after WS closed #3

Open
austinkelleher opened this issue Feb 16, 2019 · 1 comment
Open

Uncaught exception when WebSocketSend called after WS closed #3

austinkelleher opened this issue Feb 16, 2019 · 1 comment

Comments

@austinkelleher
Copy link

An uncaught exception will occur if WebSocketSend is called after the ws property on the instance has already been deleted here: https://github.com/jirihybek/unity-websocket-webgl/blob/master/Plugins/WebSocket.jslib#L205

Uncaught TypeError: Cannot read property 'readyState' of undefined

This is because the WebSocketSend method only checks for null, but in this case the value would be undefined here: https://github.com/jirihybek/unity-websocket-webgl/blob/master/Plugins/WebSocket.jslib#L258

I will have a PR with the fix momentarily.
austinkelleher added a commit to austinkelleher/unity-websocket-webgl that referenced this issue Feb 16, 2019
@austinkelleher
Fixes jirihybek#3 - Uncaught exception when WebSocketSend called afte…
518e93b 
…r WS closed.
@austinkelleher austinkelleher mentioned this issue Feb 16, 2019
Closed
@XtroTheArctic
Copy link

XtroTheArctic commented Apr 14, 2021 •
edited
Loading

This PR fixed my problem. Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@austinkelleher @XtroTheArctic